From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: Please don't use revision numbers on commit messages (and elsewhere). Date: Fri, 1 Apr 2011 01:14:37 +0200 Message-ID: References: <877hbfvwyo.fsf@wanadoo.es> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1301613330 2803 80.91.229.12 (31 Mar 2011 23:15:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 31 Mar 2011 23:15:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?UTF-8?Q?=C3=93scar_Fuentes?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 01 01:15:26 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5R5K-0006Dc-AA for ged-emacs-devel@m.gmane.org; Fri, 01 Apr 2011 01:15:26 +0200 Original-Received: from localhost ([127.0.0.1]:39074 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5R5J-0003IC-B2 for ged-emacs-devel@m.gmane.org; Thu, 31 Mar 2011 19:15:25 -0400 Original-Received: from [140.186.70.92] (port=43337 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5R5E-0003Hx-2j for emacs-devel@gnu.org; Thu, 31 Mar 2011 19:15:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5R5C-0001h9-UJ for emacs-devel@gnu.org; Thu, 31 Mar 2011 19:15:19 -0400 Original-Received: from mail-yx0-f169.google.com ([209.85.213.169]:61012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5R5C-0001h5-Os for emacs-devel@gnu.org; Thu, 31 Mar 2011 19:15:18 -0400 Original-Received: by yxt33 with SMTP id 33so1428068yxt.0 for ; Thu, 31 Mar 2011 16:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=4HnfdKYC2G2RiqgtaLxu6mzzxqZcEIotag0yCkbrSgY=; b=QX/Z4k1C1Hx58xaZBND3Zmqc647DJn1Il8XTKjVlBhpnsD0EaaXdJc4gwjAv47Oi9S p9cyLLb6PnG9oq0TrNUVXhXfUvHceuxNL5vWLjz8DIVSXWPYWhywctBavbCqwUlgBpmc EQXkccMGEyyDy6olM97Kf35+qvb83WaaFkxrs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=E55ecW8JeeUx6tPnv2sKw24HuwUQh5ZEBT+hO+M8TvpBXlfobHFPY4zB+a9Fq7/+Q+ xWt+0asGgoCXY9tWfb+itPMBEaVSPYlJxsJMN7iWqqkaeecW8Yzm7DQrTonxC85RfAtR aYX9kSISsfUWjqYPglk4uVPLIOZhgMnW2dvww= Original-Received: by 10.236.73.230 with SMTP id v66mr4575857yhd.134.1301613318178; Thu, 31 Mar 2011 16:15:18 -0700 (PDT) Original-Received: by 10.147.182.17 with HTTP; Thu, 31 Mar 2011 16:14:37 -0700 (PDT) In-Reply-To: <877hbfvwyo.fsf@wanadoo.es> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.213.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137958 Archived-At: On Thu, Mar 31, 2011 at 22:47, =C3=93scar Fuentes wrote: > A revision number only makes sense on the branch where it was created > (and this only after setting some options, as Emacs did.) Yeah, well, we're dealing with Emacs, not some random bzr branch. > If I'm reading > the VC log on a random branch and see "Fix breakage introduced by rXXXX" > and want to look at the referenced revision, I need to switch to trunk > and hope that XXXX corresponds to one of its revisions. Revision numbers refering to the trunk seem to be, until now, the most common case. And I see that people sometimes uses the branch name as an adjetive to clarify which one contains the revno: Merge from emacs-23 branch, up to r100386. emacs-23 r100373 is rendered unnecessary by pre-existing 2010-05-20 trunk change. Backport revno:103582 from trunk. Fix the MS-Windows build broken by r102878 and emacs-23/r100409. Seems pretty clear to me. > If a series of > commits on a feature branch mentions one another by revison number, > after merging them into trunk (or into any other branch) those numbers > are wrong. Isn't that a case of "if it hurts, don't do that"? > So, if you wish to refer to another revision on the commit message (or > anywhere else) please use the revision id, which is unique for every > commit. It's also quite unwieldy. git SHA-1 ids seem a joy by comparison (at least you can use a prefix of 6-8 characters and be right most of the time). =C2=A0 =C2=A0 Juanma