From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ben Key Newsgroups: gmane.emacs.devel Subject: Build error in NeXTstep (Mac OS X) Build of Emacs Date: Sun, 27 Mar 2011 00:01:49 -0500 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=bcaec52e64f5b060ed049f6fba58 X-Trace: dough.gmane.org 1301202148 3924 80.91.229.12 (27 Mar 2011 05:02:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 27 Mar 2011 05:02:28 +0000 (UTC) To: Emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 27 07:02:24 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q3i7M-00048p-8d for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2011 07:02:24 +0200 Original-Received: from localhost ([127.0.0.1]:45226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q3i7L-0004Ia-Cw for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2011 01:02:23 -0400 Original-Received: from [140.186.70.92] (port=55834 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q3i79-0004IV-6W for Emacs-devel@gnu.org; Sun, 27 Mar 2011 01:02:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q3i78-0004G4-B9 for Emacs-devel@gnu.org; Sun, 27 Mar 2011 01:02:11 -0400 Original-Received: from mail-bw0-f41.google.com ([209.85.214.41]:38436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q3i78-0004Fz-4P for Emacs-devel@gnu.org; Sun, 27 Mar 2011 01:02:10 -0400 Original-Received: by bwz17 with SMTP id 17so2056685bwz.0 for ; Sat, 26 Mar 2011 22:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:from:date:message-id:subject:to :content-type; bh=rLAuQqy9JJ0rgMabvwQtGSCdeDdPRVZ2bIwlJtUEJwg=; b=Hy8YfP1Ru6ggtXBEcs3IaZs4HgQQb8UxD9aOxJu0x8OfI61/uDcq7Uw/l4hFm9Jd2q LwyVrKb2RHWaHc+DdcZUptvzJiGQ3aPh32eQBE8P0ZxtCNNKZ74T2/vmPPOl4hIdb/q6 hNON4uNgRywHccEe8N38uLnkItE+dW4wYXuMg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=xaLRlmxqaVAe1i+FcT6KnzH/s7cvp7UtYvSKfiiuRmYa6rVjbsd0gzbk3jGG+41URa J+crDakoHPiB2sffqKio/D8m62nx0nLalCe6XQrf5iwwq48HpLHQR+oVWCwN5Hxf89Uy 3eXXIbha50MtOhEz9ofS52c8jSkOM46MN1gUk= Original-Received: by 10.204.169.130 with SMTP id z2mr2248957bky.137.1301202129149; Sat, 26 Mar 2011 22:02:09 -0700 (PDT) Original-Received: by 10.204.151.212 with HTTP; Sat, 26 Mar 2011 22:01:49 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.214.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137741 Archived-At: --bcaec52e64f5b060ed049f6fba58 Content-Type: text/plain; charset=ISO-8859-1 Revision 103754 caused a couple of compilation errors in nsmenu.m due to the fact that the do_it_now parameter of timer_check was still used. The following patch resolves this problem. There are two changes in this patch. 1. Remove the declaration of the timer_check function from nsmenu.m so that the declaration of the function found in keyboard.h will be used. 2. Modify the one call to the timer_check function in nsmenu.m so that it no longer attempts to specify a value for the do_it_now parameter. === modified file 'src/nsmenu.m' --- src/nsmenu.m 2011-01-25 04:08:28 +0000 +++ src/nsmenu.m 2011-03-27 04:35:16 +0000 @@ -1705,7 +1705,6 @@ - (Lisp_Object)runDialogAt: (NSPoint)p { NSInteger ret; - extern EMACS_TIME timer_check (int do_it_now); /* TODO: add to a header */ /* initiate a session that will be ended by pop_down_menu */ popupSession = [NSApp beginModalSessionForWindow: self]; @@ -1715,7 +1714,7 @@ { /* Run this for timers.el, indep of atimers; might not return. TODO: use return value to avoid calling every iteration. */ - timer_check (1); + timer_check (); [NSThread sleepUntilDate: [NSDate dateWithTimeIntervalSinceNow: 0.1]]; } --bcaec52e64f5b060ed049f6fba58 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Revision 103754 caused a couple of compilation errors in nsmenu.m due to th= e fact that the do_it_now parameter of timer_check was still used.=A0 The f= ollowing patch resolves this problem.

There are two changes in this = patch.
  1. Remove the declaration of the timer_check function from nsmenu.m so= that the declaration of the function found in keyboard.h will be used.
  2. Modify the one call to the timer_check function in nsmenu.m so that it= no longer attempts to specify a value for the do_it_now parameter.

<patch>
=3D=3D=3D modified file 'src/nsmenu.m'--- src/nsmenu.m=A0=A0=A0 2011-01-25 04:08:28 +0000
+++ src/nsmenu.m=A0= =A0=A0 2011-03-27 04:35:16 +0000
@@ -1705,7 +1705,6 @@
=A0- (Lisp_Obj= ect)runDialogAt: (NSPoint)p
=A0{
=A0=A0 NSInteger ret;
-=A0 extern EMACS_TIME timer_check (int do= _it_now); /* TODO: add to a header */
=A0
=A0=A0 /* initiate a sessio= n that will be ended by pop_down_menu */
=A0=A0 popupSession =3D [NSApp = beginModalSessionForWindow: self];
@@ -1715,7 +1714,7 @@
=A0=A0=A0=A0 {
=A0=A0=A0=A0=A0=A0 /* Run this f= or timers.el, indep of atimers; might not return.
=A0=A0=A0=A0=A0=A0=A0= =A0=A0 TODO: use return value to avoid calling every iteration. */
-=A0= =A0=A0=A0=A0 timer_check (1);
+=A0=A0=A0=A0=A0 timer_check ();
=A0=A0=A0=A0=A0=A0 [NSThread sleepUntilDate: [NSDate dateWithTimeIntervalSi= nceNow: 0.1]];
=A0=A0=A0=A0 }
=A0

</patch>

--bcaec52e64f5b060ed049f6fba58--