unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org
Subject: Re: `C-h v' may offer too many symbols
Date: Thu, 10 Mar 2011 20:39:48 +0100	[thread overview]
Message-ID: <AANLkTikQ30y3e1iewy+xbdVLDBNoSztWEyJy482zGfPF@mail.gmail.com> (raw)
In-Reply-To: <87y64mkdu3.fsf@lifelogs.com>

2011/3/10 Ted Zlatanov <tzz@lifelogs.com>:

> `C-h v' offers completion candidates like :AFTER and :border which are
> not documented and self-quoting.  Is that a good idea?  They don't seem
> useful to me.  Maybe at least self-quoting symbols without a docstring
> should be excluded.

Yes, it is a bit silly complete keywords, which are not variables by definition.
I'm going to install this trivial fix.

    Juanma



2011-03-10  Juanma Barranquero  <lekktu@gmail.com>

	* help-fns.el (describe-variable): Don't complete keywords.
	Suggested by Teodor Zlatanov <tzz@lifelogs.com>.


=== modified file 'lisp/help-fns.el'
--- lisp/help-fns.el	2011-02-24 08:26:25 +0000
+++ lisp/help-fns.el	2011-03-10 19:32:46 +0000
@@ -593,8 +593,9 @@
 				  "Describe variable: ")
 				obarray
 				'(lambda (vv)
-				   (or (boundp vv)
-				       (get vv 'variable-documentation)))
+				  (unless (keywordp vv)
+				    (or (boundp vv)
+					(get vv 'variable-documentation))))
 				t nil nil
 				(if (symbolp v) (symbol-name v))))
      (list (if (equal val "")



  reply	other threads:[~2011-03-10 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 18:52 `C-h v' may offer too many symbols Ted Zlatanov
2011-03-10 19:39 ` Juanma Barranquero [this message]
2011-03-11  2:10   ` Stefan Monnier
2011-03-11  2:27     ` Juanma Barranquero
2011-03-11  4:29       ` Stefan Monnier
2011-03-11  4:31     ` public APIs and private ones (Re: `C-h v' may offer too many symbols) Kenichi Handa
2011-03-11  5:41       ` public APIs and private ones (Re: `C-h v' may offer too manysymbols) Drew Adams
2011-03-11 19:08       ` public APIs and private ones (Re: `C-h v' may offer too many symbols) Ted Zlatanov
2011-03-11 20:28       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikQ30y3e1iewy+xbdVLDBNoSztWEyJy482zGfPF@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).