From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: bug#6781: emacs server with X11 build on OSX Date: Fri, 24 Sep 2010 21:38:28 +0200 Message-ID: References: <83F33443-0C3F-4F9B-B584-D9301250B8FC@raeburn.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1285357165 24678 80.91.229.12 (24 Sep 2010 19:39:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Sep 2010 19:39:25 +0000 (UTC) Cc: 6781@debbugs.gnu.org, Ken Raeburn , Leo , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 24 21:39:23 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OzE75-0008Pk-Qv for ged-emacs-devel@m.gmane.org; Fri, 24 Sep 2010 21:39:20 +0200 Original-Received: from localhost ([127.0.0.1]:32935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzE75-00084J-0l for ged-emacs-devel@m.gmane.org; Fri, 24 Sep 2010 15:39:19 -0400 Original-Received: from [140.186.70.92] (port=33179 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzE6y-00084D-2W for emacs-devel@gnu.org; Fri, 24 Sep 2010 15:39:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OzE6w-0004Di-Kc for emacs-devel@gnu.org; Fri, 24 Sep 2010 15:39:11 -0400 Original-Received: from mail-iw0-f169.google.com ([209.85.214.169]:57671) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OzE6w-0004Da-Fk for emacs-devel@gnu.org; Fri, 24 Sep 2010 15:39:10 -0400 Original-Received: by iwn33 with SMTP id 33so4282124iwn.0 for ; Fri, 24 Sep 2010 12:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=Gp7LmfD8U3yjqoBRYcOEGN6UJp+C1Y7dPaXXUMhPAzE=; b=mWFkgrwYHlKVpE5zc/bVLJrDtvhOWiHP+2l6nKcFD/6vhO7K4B6nEncLFym0l3y7tn hvS6Dc6hhTFInFIb+31kiuy76JbjjHH5o1USW3GtYZrgLlNYB84mn7sdz0BNRrQtyZDp T9wqNfKf8c5fybmTyWPNkCv7wMT+YBQfYpBCU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=vIlNDZDXUiTFEhVV7oSuPOf6bMC7lHIfwhpQyU0vPcYtzDm15lRKr11OkDjUIozEpE iDe+M4uXZNfqOjBQ2XZiNf29f9f1/CyhtarMYqvoUwF8qU8h6ZfT9cxtULVGIhyAZiM9 KwxafmDU5x4cXMGuoOGcpiLXvDVNvfClAxlTk= Original-Received: by 10.231.119.229 with SMTP id a37mr2642392ibr.169.1285357149325; Fri, 24 Sep 2010 12:39:09 -0700 (PDT) Original-Received: by 10.231.196.71 with HTTP; Fri, 24 Sep 2010 12:38:28 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130801 Archived-At: On Tue, Aug 10, 2010 at 15:31, Stefan Monnier wr= ote: > >> But, all in all, I agree that if `localhost' can be interpreted as >> variably as Ken has pointed out, we shouldn't use it. > > Could you make the corresponding change in `trunk'? OK to this change, then? =C2=A0 =C2=A0 Juanma 2010-09-24 Juanma Barranquero * server.el (server-start): Revert part of 2010-08-08 change. Using address 127.0.0.1 for local host is now done in Fmake_network_process. 2010-09-24 Juanma Barranquero * process.c (Fmake_network_process): When arg :host is 'local, use address 127.0.0.1, not name "localhost". (Bug#6781) =3D=3D=3D modified file 'lisp/server.el' --- lisp/server.el 2010-08-26 13:46:19 +0000 +++ lisp/server.el 2010-09-24 19:16:01 +0000 @@ -565,7 +565,7 @@ (if server-use-tcp (list :family 'ipv4 ;; We're not ready for IPv6 yet :service t - :host (or server-host "127.0.0.1") ;; See bug#6781 + :host (or server-host 'local) :plist '(:authenticated nil)) (list :family 'local :service server-file =3D=3D=3D modified file 'src/process.c' --- src/process.c 2010-09-17 15:47:49 +0000 +++ src/process.c 2010-09-24 19:31:13 +0000 @@ -3170,7 +3170,9 @@ if (!NILP (host)) { if (EQ (host, Qlocal)) - host =3D build_string ("localhost"); + /* Depending on setup, "localhost" may map to different IPv4 and/or + IPv6 addresses, so it's better to be explicit. (Bug#6781) */ + host =3D build_string ("127.0.0.1"); CHECK_STRING (host); }