unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Deniz Dogan <deniz.a.m.dogan@gmail.com>
To: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: [PATCH] delete-trailing-whitespace on active region
Date: Wed, 9 Feb 2011 19:28:35 +0100	[thread overview]
Message-ID: <AANLkTi=pRUpJdGixFMQQV_Z0-CfqTSR86cDHmL7W0uey@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

I have found myself in need of deleting trailing whitespace only in a
specific region from time to time.  Therefore, I wrote this patch
which changes the behavior of the command to act only on the region if
it is active.

So before I commit this, I'd like to check it with you guys.

Is this new behavior okay?  If so, is this patch okay?

--
Deniz Dogan

[-- Attachment #2: dtw.patch --]
[-- Type: application/octet-stream, Size: 1820 bytes --]

=== modified file 'lisp/simple.el'
--- lisp/simple.el	2011-02-01 21:22:21 +0000
+++ lisp/simple.el	2011-02-09 18:15:31 +0000
@@ -614,22 +614,25 @@
     (if (looking-at "^[ \t]*\n\\'")
 	(delete-region (point) (point-max)))))
 
-(defun delete-trailing-whitespace ()
+(defun delete-trailing-whitespace (&optional start end)
   "Delete all the trailing whitespace across the current buffer.
 All whitespace after the last non-whitespace character in a line is deleted.
 This respects narrowing, created by \\[narrow-to-region] and friends.
-A formfeed is not considered whitespace by this function."
-  (interactive "*")
+A formfeed is not considered whitespace by this function.
+If the region is active, only delete whitespace within the region."
+  (interactive "*r")
   (save-match-data
     (save-excursion
-      (goto-char (point-min))
-      (while (re-search-forward "\\s-$" nil t)
-	(skip-syntax-backward "-" (save-excursion (forward-line 0) (point)))
-	;; Don't delete formfeeds, even if they are considered whitespace.
-	(save-match-data
-	  (if (looking-at ".*\f")
-	      (goto-char (match-end 0))))
-	(delete-region (point) (match-end 0))))))
+      (let ((start (or (and (region-active-p) start) (point-min)))
+            (end (or (and (region-active-p) end) (point-max))))
+        (goto-char start)
+        (while (re-search-forward "\\s-$" end t)
+          (skip-syntax-backward "-" (save-excursion (forward-line 0) (point)))
+          ;; Don't delete formfeeds, even if they are considered whitespace.
+          (save-match-data
+            (if (looking-at ".*\f")
+                (goto-char (match-end 0))))
+          (delete-region (point) (match-end 0)))))))
 
 (defun newline-and-indent ()
   "Insert a newline, then indent according to major mode.


             reply	other threads:[~2011-02-09 18:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 18:28 Deniz Dogan [this message]
2011-02-10  2:35 ` [PATCH] delete-trailing-whitespace on active region Stefan Monnier
2011-02-10 15:31   ` Deniz Dogan
2011-02-10 19:05     ` Stefan Monnier
2011-02-10 21:31     ` Johan Bockgård
2011-02-11  2:10       ` Stefan Monnier
2011-02-11  6:33         ` Deniz Dogan
2011-02-11 14:30           ` Stefan Monnier
2011-02-11 18:27             ` Deniz Dogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=pRUpJdGixFMQQV_Z0-CfqTSR86cDHmL7W0uey@mail.gmail.com' \
    --to=deniz.a.m.dogan@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).