From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Initial fontification in sh-mode with tree-sittter Date: Fri, 28 Oct 2022 10:44:07 -0700 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40492"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , =?utf-8?Q?Jo=C3=A3o_Paulo_Labegalini_de_Carvalho?= , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 28 19:45:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooTQF-000AIU-A2 for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Oct 2022 19:45:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooTP9-0002fZ-Td; Fri, 28 Oct 2022 13:44:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooTOu-0002b5-5o for emacs-devel@gnu.org; Fri, 28 Oct 2022 13:44:12 -0400 Original-Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooTOs-0005Zx-LF for emacs-devel@gnu.org; Fri, 28 Oct 2022 13:44:11 -0400 Original-Received: by mail-pj1-x1034.google.com with SMTP id m6-20020a17090a5a4600b00212f8dffec9so5180521pji.0 for ; Fri, 28 Oct 2022 10:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hByk9GH+bE/uNS5ZoP/DMDb/fccvgNJfkhZd9FWU8ZY=; b=LIEd9GHhp+Qh1KxdfE+pjg29KL68u9ZFB2ybbsRyvzDj9GKm5glMTuQr+/+c03BGc7 NN1o/CXXsEP6prjpdT6Q8P7UsPJ3VLExQYNhta208L1X0HVMBe0YUPAQgtfSjxetLafD vSCkFq92ILlbimN0F+pdykVzzOpzWNclyoavYxPAeBuYM5BuPXxyMhj51GJILsZy2/1n XsmghxKYfqf73dVHbh43mv6+lrH5cSkIjynJFX78DRgfpNotAUTIY+DQh1S/gUrjkOBb PdU2CJkGle5gImYkIJRYJ1DuLR2JyK0hiopezAIuYkw5RXYL8L7Jo3GDBo/wkbfQNSdH hcTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hByk9GH+bE/uNS5ZoP/DMDb/fccvgNJfkhZd9FWU8ZY=; b=ldzWQsu8Uq4HX9zbzOMq3KI/fRFV3KWKtip5V6Zf3OtHN03zHeh6dKkYQlyHy2aeNr ktaaDwaBvIKKSvzhrBtQ+s0tGAefaRWbWLSMrHToXMkzwzdEJRRknB1UOFY2v/xQMQbW 0UElLGUSBIhNXl5Z1JeVDXJ1ZfBUz9htDGHqSWp0vT16WbMEBYM2oNddSJ7zYOM9bzBt JNFUibARuFLO5yh27ZFv9XagfKw29Ls2/sGD8H1oCGQ+ap31dV8STaKcKaYbM0xkItmq QvNFFyDX1S/O/HMMOAx0WEI2Dm9DCdMG7NETl1zhzhSuqHdn6P3YTPk0petUvLZjv1Iu Ud/A== X-Gm-Message-State: ACrzQf2iZVbMNPLwSwXNvykBVn/whKkdiZFQJd4/WjmwjRlFFEYu7Rvj agOCfZkSDrL7NdKShqOIexY= X-Google-Smtp-Source: AMsMyM6ILd8mB4cAKNHDbLjKuEg4SLuLHxmOJ/T/g3Umu+84DxxMQITj8OYdeyoaDNXnpblQQjpwVQ== X-Received: by 2002:a17:903:2348:b0:186:970e:739e with SMTP id c8-20020a170903234800b00186970e739emr98482plh.115.1666979048998; Fri, 28 Oct 2022 10:44:08 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id f12-20020a170902ce8c00b0017ec1b1bf9fsm3388678plg.217.2022.10.28.10.44.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2022 10:44:08 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=casouri@gmail.com; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298687 Archived-At: > On Oct 28, 2022, at 9:15 AM, Stefan Monnier = wrote: >=20 > Stefan Kangas [2022-10-28 08:57:07] wrote: >> Jo=C3=A3o Paulo Labegalini de Carvalho writes: >>> + (setq-local treesit-font-lock-feature-list >>> + '((basic) (moderate) (elaborate))) >> I see that most modes on the branch seem to be using those three = symbols >> for now. >=20 > Indeed, it's sad. It's goes against the idea being > `treesit-font-lock-feature-list` which is to map features to levels. >=20 > It doesn't make much sense to call a highlight feature "moderate". > Highlight feature names should be things like "function names", = "nested > functions", "multiline docstrings", "punctuation=E2=80=9D. Yeah it=E2=80=99s a kind of placeholder, plus a test for = font-lock-maximum-decoration. I plan to refine it once I=E2=80=99m done = with more pressing problems. Yuan