unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master d08c947: Make compilation-mode regexp matching case-sensitive (bug#40119)
Date: Wed, 25 Mar 2020 23:29:50 +0100	[thread overview]
Message-ID: <AA720D82-0063-4A0E-81A8-B3F4C8E7A979@acm.org> (raw)
In-Reply-To: <jwvpnd040rn.fsf-monnier+emacs@gnu.org>

25 mars 2020 kl. 21.54 skrev Stefan Monnier <monnier@iro.umontreal.ca>:

> The regular expressions are written either with or without case-folding
> in mind, so changing it globally is a recipe for problems.

Agreed, but I doubt that anyone will ever set the option. It was added just in case someone has a tool emitting messages that happens to match one of the built-in rules if case-folding is used, or if a user has added a sloppily written regexp. In either case, adding a properly written regexp is of course the recommended action.

> If we want to allow case-insensitive regexp matching, then we should
> extend the syntax of `compilation-error-regexp-alist` so that a given
> entry there can request it to be used with case-folding.

It would be more flexible, but I'd rather not add the complexity without evidence of a need for it.

> PS: The same applies to the "zero/one-based column numbers" and
>    the "char-colums vs visual-columns vs byte-columns", admittedly.

Yes, those settings would make more sense if they were rule-specific. Still, actual examples of tools needing them would be useful.




  reply	other threads:[~2020-03-25 22:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200325204155.5002.75177@vcs0.savannah.gnu.org>
     [not found] ` <20200325204157.3643820E43@vcs0.savannah.gnu.org>
2020-03-25 20:54   ` master d08c947: Make compilation-mode regexp matching case-sensitive (bug#40119) Stefan Monnier
2020-03-25 22:29     ` Mattias Engdegård [this message]
2020-03-26  3:42       ` Stefan Monnier
2020-03-26 16:25         ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AA720D82-0063-4A0E-81A8-B3F4C8E7A979@acm.org \
    --to=mattiase@acm.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).