From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: feature/tree-sitter 3069849bd4 4/4: * src/treesit.c (treesit_load_language): Fix uninitialized uses. Date: Mon, 21 Nov 2022 01:37:13 -0800 Message-ID: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40101"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 21 10:38:51 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ox3GL-000ABD-Ny for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Nov 2022 10:38:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox3FA-00045R-M5; Mon, 21 Nov 2022 04:37:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox3F5-00045A-8p for emacs-devel@gnu.org; Mon, 21 Nov 2022 04:37:31 -0500 Original-Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ox3Er-0003E4-O6 for emacs-devel@gnu.org; Mon, 21 Nov 2022 04:37:25 -0500 Original-Received: by mail-pj1-x1032.google.com with SMTP id q96-20020a17090a1b6900b00218b8f9035cso1572486pjq.5 for ; Mon, 21 Nov 2022 01:37:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=qgO0RVFbD9vuYqJdr6eFZPraoYVFLDQ8qEDG8Fd8edk=; b=ACgkYMovdLOgetVTtV3ch6EsTYCX2Jjwu6TCMqMnC4P546ZFj56pvGq+TfAEdRYqXL 07mezQdZY0k3/uPrM1w/AobPIjMQMbf0Imv2J/zCBmI8rGyWe0IyB7hMwyggaCkFmMpH j5PJwxDkSkYIsdONmSEmKhqz4THVk+8E3jKy4NjQ6vcSF4js4AfYMaKqOeVUo1Tjm6VQ sdrGVd0fo6ocRRQQsrWjNrMnHZV7lWoK9TvNYt98kENMe4KMqO++DQMw4H8VDOrIChKb KjMCyEc0mN4aYdZ4GkWWjlv6RB65iqqFRvuGFBl1thfk+JZJKSajo78SxtjBMwywf6ic sddg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qgO0RVFbD9vuYqJdr6eFZPraoYVFLDQ8qEDG8Fd8edk=; b=EmqdizXte984zKLkZHYmD+yP8Mc9dsJs0blv7wh1oZjBd1cA92j+wvitLpvVHgbZhv iC5aClxQ1LQ0q2ycnfLkamF5bLJ4GqAcW5LYO+uNlh+g+aqTgURusoIuzYArLtqB46sQ nkqGizD8AvAMnAgPtS2/gOwjXSP9K3Ybd+01ZfhQQrcMcFgIXT0Kj8r8iZQSQcIa9eRQ uH35itamoKwxlJ8CGROGqfFn8sIzmdKKY3ppKpOR/hhEDGXGv2TtQ1cqQ2rhneSSKuOh eJrrdjnirA0S/RrKuU7oalCr9Rlz3MX2AMBjyo7k88XQjWaiC0BjiMWPSsyGPOe1MCnP 8aNw== X-Gm-Message-State: ANoB5plcC0e0eUlZvOCJ8pJrTKRxm2T6k/qiedwGZG1ZkjuxcDGXY8zz bcBsX1ieJXpuopcOpnwVodI= X-Google-Smtp-Source: AA0mqf7mDI716uvrAlfGVtQOxNhphlC/Zr1OqY7VkBkIjhTIPVSEnxqRzv+mEuiKexUbmfNMTmTDrQ== X-Received: by 2002:a17:90a:17cb:b0:218:a9e2:196a with SMTP id q69-20020a17090a17cb00b00218a9e2196amr5712324pja.245.1669023435277; Mon, 21 Nov 2022 01:37:15 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id c16-20020a170903235000b00186f0f59c85sm3395195plh.235.2022.11.21.01.37.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2022 01:37:15 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=casouri@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300286 Archived-At: branch: feature/tree-sitter commit 3069849bd4c1048a8f8c0467d26560fad939e791 Author: Po Lu Commit: Po Lu * src/treesit.c (treesit_load_language): Fix uninitialized uses. --- src/treesit.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/treesit.c b/src/treesit.c index 291698e4e4..599a9b883e 100644 --- a/src/treesit.c +++ b/src/treesit.c @@ -554,9 +554,11 @@ treesit_load_language (Lisp_Object language_symbol, when succeed, record the error message and try the next one when fail. */ dynlib_handle_ptr handle; - char const *error; + const char *error; =20 tail =3D path_candidates; + error =3D NULL; + handle =3D NULL; =20 FOR_EACH_TAIL (tail) { @@ -568,6 +570,9 @@ treesit_load_language (Lisp_Object language_symbol, break; } =20 + /* ??? */ + eassume (handle !=3D NULL); + if (error !=3D NULL) { *signal_symbol =3D Qtreesit_load_language_error; Thanks for working on this. What does ??? mean? Why do we assume handle = is not NULL?