From: Yuan Fu <casouri@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 361c5fc2d8e 3/3: Support more predicates in tree-sitter search functions
Date: Fri, 14 Apr 2023 17:05:32 -0700 [thread overview]
Message-ID: <A8D758E7-9523-40B8-8BC7-AE3F3356FADD@gmail.com> (raw)
In-Reply-To: <87jzyfjd8q.fsf@yahoo.com>
> On Apr 13, 2023, at 9:31 PM, Po Lu <luangruo@yahoo.com> wrote:
>
> Yuan Fu <casouri@gmail.com> writes:
>
>> Ok, I can add a recursion limit check.
>
> Great, thanks.
>
>> Is it really necessary? IMHO having the braces is clearer when the statement has more than one line.
>
> We prefer to avoid redundant braces, yes.
If you insist, ok.
>> I like to always initialize variables.
>
> OK, but this wastes cycles.
>
>> Either way should be fine. I’ve been using the current style
>> throughout treesit.c.
>
> The compiler cannot perform automatic register allocation on
> `signal_data' your way.
While you are absolutely right, the performance benefit surely would be negligible, no?
Yuan
next prev parent reply other threads:[~2023-04-15 0:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168142374534.3804.10641447592850495150@vcs2.savannah.gnu.org>
[not found] ` <20230413220905.CB635C13A82@vcs2.savannah.gnu.org>
2023-04-13 23:50 ` master a5eb9f6ad4e 2/3: Catch signals produced by PRED in tree-sitter search functions Po Lu
[not found] ` <20230413220905.E3C7BC13A84@vcs2.savannah.gnu.org>
2023-04-13 23:55 ` master 361c5fc2d8e 3/3: Support more predicates " Po Lu
2023-04-14 1:57 ` Yuan Fu
2023-04-14 4:31 ` Po Lu
2023-04-15 0:05 ` Yuan Fu [this message]
2023-04-15 0:18 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A8D758E7-9523-40B8-8BC7-AE3F3356FADD@gmail.com \
--to=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).