From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Initial fontification in sh-mode with tree-sittter Date: Sat, 12 Nov 2022 23:01:30 -0800 Message-ID: References: <6C8B0F8E-DF61-4BC3-B0D0-56DBB66BE637@gmail.com> <7AE71CCA-6F18-4DE6-8608-7D9B3E9E52FB@gmail.com> <9BA853EA-8B7F-41A0-A174-D86DF5CE7788@gmail.com> <83sfj3cfl0.fsf@gnu.org> <03309451-1AEB-458C-88FD-9715CECC27A2@gmail.com> <83mt9bc9ke.fsf@gnu.org> <8335b19ndr.fsf@gnu.org> <39ECD413-BD10-4BF3-90AC-36F02276607E@gmail.com> <8A2361BB-1081-4550-AC29-B9E99BFC2FB8@gmail.com> <42DBD4F5-71D9-434E-B7B4-4E0FF89F934F@gmail.com> <83edu7mkza.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32057"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?Q?Jo=C3=A3o_Paulo_Labegalini_de_Carvalho?= , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 13 08:02:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ou70Y-0008EZ-T1 for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Nov 2022 08:02:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ou709-00045N-Pr; Sun, 13 Nov 2022 02:01:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ou6zv-0003rZ-Ow for emacs-devel@gnu.org; Sun, 13 Nov 2022 02:01:49 -0500 Original-Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ou6zt-0007Me-LZ; Sun, 13 Nov 2022 02:01:43 -0500 Original-Received: by mail-pg1-x52f.google.com with SMTP id n17so93853pgh.9; Sat, 12 Nov 2022 23:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DDkMxpewn6rePNP0JffJw2r/jhRaEfHT3Jwa0qqVWy0=; b=oXWNcjrlSB3UHWSBCLmwgjkDarSTS7k/sgD2cNHA+/4jhz+d9X1FigkGBa/PLJ5PBF OCCf7ogxfWSIldUGAvZAxSk3STAyoMggT5fGEi/0xqEPX15+2hE+R5JFEtZlfWDQmF8K PfWNxHffBf0wIpAFEM9R1u4C7/M4k80XxrraBxI8ZH2VYWU36IRuxPl0pjjNWfxgLuJX e7/xVKbA5H7GDXc4/hb9l65tqL9vmLZjs6bkBkfSjZnERZjyqKncOGxYuGYVQ1D7QIA2 6RD4Plh/4ga7QD2HbW17kHtUxCj5f8FKgVqIGd9Xnbdgy1TQS64NhITvhznuhrPo+NhX k32A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DDkMxpewn6rePNP0JffJw2r/jhRaEfHT3Jwa0qqVWy0=; b=nTMqRHbwbU4kWZJ+Gr9tKKKsv6B2Xwd5lMAYMzNsc7wF6X/yWLVwgeg7eMxsA//W1K Pt03T09AxIZvryL1zNp6OVcPz+EpB3pch4yyvlt1Kmmb/ikU0SdYOdW0bu1QGdGOfUqd qWe4o5hkN2eF02FFdnsdemofO9HXyQ9ZP9GFmh/Zf657EaFKZIamo4scHXE3pAVnB6hu zB731axuSNaikr2mYi2sSwlXJbcLeswFFhNWdgT7URFqnhC3BgqkeF9VksqqUfMgZJ83 +Q/5XliV3FYlJg51MlgDndxo/hgw+NFLZPqdeevkJG+vZ/3Oz/XV+JLYw8hSZJ59HEW2 U5rA== X-Gm-Message-State: ANoB5plymOpqdxRVf4vj11BMI9verukmSZ3B7WBhtzj7MgrF2iLHGgAX N8dvaCJHFsKib6YL9PuzRUcewAfwsCU= X-Google-Smtp-Source: AA0mqf5VNHH4MNPX229BSEvt1xkdPCtYD5QtFt3Ujr6cXpV1H8RDbiONwf974WhIrd5/eL2WMFJ/xw== X-Received: by 2002:a05:6a00:2190:b0:562:45f0:df50 with SMTP id h16-20020a056a00219000b0056245f0df50mr9610729pfi.16.1668322899584; Sat, 12 Nov 2022 23:01:39 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id k26-20020aa7999a000000b00561382a5a25sm4223092pfh.26.2022.11.12.23.01.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Nov 2022 23:01:33 -0800 (PST) In-Reply-To: <83edu7mkza.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=casouri@gmail.com; helo=mail-pg1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299704 Archived-At: > On Nov 12, 2022, at 10:23 PM, Eli Zaretskii wrote: >=20 >> From: Jo=C3=A3o Paulo Labegalini de Carvalho >> Date: Sat, 12 Nov 2022 15:04:26 -0700 >> Cc: Eli Zaretskii , emacs-devel@gnu.org >>=20 >> I see. This is tree-sitter-bash=E2=80=99s problem. When there are = only newlines between two EOF=E2=80=99s, the parser >> erroneously marks everything that follows as heredoc_body. I tried = tree-sitter=E2=80=99s online demo and it gives >> the same result[1]. We should report this to tree-sitter-bash=E2=80=99s= author. >>=20 >> Sorry for the delay. I confirmed the problem was in the = tree-sitter-bash side and submitted a PR to fix it: >> https://github.com/tree-sitter/tree-sitter-bash/pull/137 >> Once my fixes are pulled in, there is no change required to my patch. >=20 > Do we need to wait for their fix, or can we have code that will start > working correctly when they fix the parser? We don=E2=80=99t need to wait for their fix. When they fix the parser = and users install the new parser, everything will work correctly. Yuan=