From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 fb5d9ff559 1/2: Fix c-ts-mode defun movement (bug#59628) Date: Thu, 1 Dec 2022 18:53:37 -0800 Message-ID: References: <83zgc7gmz1.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34406"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 02 03:54:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0wBg-0008iW-Gv for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Dec 2022 03:54:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0wBM-0005Bh-PC; Thu, 01 Dec 2022 21:53:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0wBL-0005BS-7o for emacs-devel@gnu.org; Thu, 01 Dec 2022 21:53:43 -0500 Original-Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0wBJ-0006TD-Pa; Thu, 01 Dec 2022 21:53:42 -0500 Original-Received: by mail-pf1-x42e.google.com with SMTP id 21so3696564pfw.4; Thu, 01 Dec 2022 18:53:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sj6ESbdULQJ4iuOc7qs5jRVBq7nXFnzGnXz2GVhzer0=; b=iFAEd2KMCU131Xeqh93AU7ImqFtey6wgkNkArJMENzB3J2Gh6A/ABQ/Jfv1AMaoVzC shCf6hw4hLqnyXR6lIkRrkfdbTASwHzRIwVU+gLvrJYgZPZwQuwj5E8HwnIUYPj8ZpCl f0pnRQkPqJJ3EsTmmBHPOibFzLFBOShF7rTGk+Ij/9KA+saUXcAS98woIQHPCJlROMKz F77NEpklCK3GfCis+dE3sI6KyyDz8axz6qZFRko0VhnJw8fmC+YAPzC+A5qJ+8+pixfM z8mrg2UuGCZV+FYyR+o2lIpgqWkiJmSkVF7cuLg4Qydofm7iB9iiRN35O2vOwQOJ4nCm XQNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sj6ESbdULQJ4iuOc7qs5jRVBq7nXFnzGnXz2GVhzer0=; b=Kv9OHxoKyc9rehzTYcirWLvDWYE5iTMEI37FDb8QKsxIDPth+eDS8Kc/9hxYpAj2Gn E/SA1SfSycqf8ybU2eIbY93Qi+x4KmqVbbMsxFUxfgHDghbj1xfLHkhZI1jgFvYMrZeQ eM3S+X2cHfNJtosiIHqDOFHH95YWFC1vb999z+wnrMeFFMOWemgkPnHn9+ECGLUscT7A eqwOZCTecv97W0afc2Z9efNLBjVH+ja26eT/5+SvWSz5jN/fJigoDYawLAvfiLjk/XkN wlGirO8vX0gQ4PkP5ddxiLIloes53NPaRjh4sRJ5MnU5Ybt+1i21K6kpd6HKI2niqX7f 1gIw== X-Gm-Message-State: ANoB5pn3GEHCJPhUPiBh7zhXkrN90Gbtu0vxFKe5FiCcBj4hE8O/otdu cnYzxHqFTMjDE9YFJR5bcRLVDSkjKAg= X-Google-Smtp-Source: AA0mqf6LvN9QYkAS5uP2jaWWmECysSf+hhvO3BAkjJTXKAhmI1/rbzXoIH5KQEHN0u8282QsSwCqkQ== X-Received: by 2002:a63:1e62:0:b0:46b:3acb:77b2 with SMTP id p34-20020a631e62000000b0046b3acb77b2mr41783067pgm.560.1669949619686; Thu, 01 Dec 2022 18:53:39 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id a14-20020a170902ecce00b00186b1bfbe79sm4390856plh.66.2022.12.01.18.53.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Dec 2022 18:53:38 -0800 (PST) In-Reply-To: <83zgc7gmz1.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=casouri@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300829 Archived-At: > On Dec 1, 2022, at 7:30 AM, Eli Zaretskii wrote: >=20 >> ;; Navigation. >> (setq-local treesit-defun-type-regexp >> - (rx (or "specifier" >> - "definition"))) >> + (rx (or "function_definition" >> + "type_definition" >> + "struct_specifier" >> + "enum_specifier" >> + "union_specifier"))) >=20 > Shouldn't we use regex-opt here? I wasn=E2=80=99t aware of this function. Though it doesn=E2=80=99t seems = to make a difference, I would expect it to transform the regex into = something like (rx (or (seq (or "function" "type") "_definition") (seq (or "struct" "enum" "union") "_specifier"))) Anyway, I changed it to use regexp-opt. Yuan=