Fixes: in vc for git?

unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed

* Fixes: in vc for git?
@ 2014-11-14  7:37 Jan D.
  2014-11-14 13:59 ` Eric S. Raymond
  2014-11-16  1:46 ` Glenn Morris
  0 siblings, 2 replies; 13+ messages in thread
From: Jan D. @ 2014-11-14  7:37 UTC (permalink / raw)
  To: emacs-devel

Hello.

Is there a way to get the automatix Fixes: <bugno> in *vc-log* like we 
had for bzr?

Thanks,

	Jan D.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-14  7:37 Fixes: in vc for git? Jan D.
@ 2014-11-14 13:59 ` Eric S. Raymond
  2014-11-14 18:41   ` David Caldwell
  2014-11-16  1:46 ` Glenn Morris
  1 sibling, 1 reply; 13+ messages in thread
From: Eric S. Raymond @ 2014-11-14 13:59 UTC (permalink / raw)
  To: Jan D.; +Cc: emacs-devel

Jan D. <jan.h.d@swipnet.se>:
> Is there a way to get the automatix Fixes: <bugno> in *vc-log* like
> we had for bzr?

Not in git itself. Our best option would be to buld something equivalent
into VC or Magit.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-14 13:59 ` Eric S. Raymond
@ 2014-11-14 18:41   ` David Caldwell
  0 siblings, 0 replies; 13+ messages in thread
From: David Caldwell @ 2014-11-14 18:41 UTC (permalink / raw)
  To: esr, Jan D.; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

On 11/14/14 5:59 AM, Eric S. Raymond wrote:
> Jan D. <jan.h.d@swipnet.se>:
>> Is there a way to get the automatix Fixes: <bugno> in *vc-log* like
>> we had for bzr?
> 
> Not in git itself. Our best option would be to buld something equivalent
> into VC or Magit.

One could also add a git post-receive hook in the master repo to do this.

-David



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-14  7:37 Fixes: in vc for git? Jan D.
  2014-11-14 13:59 ` Eric S. Raymond
@ 2014-11-16  1:46 ` Glenn Morris
  2014-11-16  4:35   ` Stefan Monnier
  2014-11-16  9:28   ` Jan D.
  1 sibling, 2 replies; 13+ messages in thread
From: Glenn Morris @ 2014-11-16  1:46 UTC (permalink / raw)
  To: Jan D.; +Cc: emacs-devel

"Jan D." wrote:

> Is there a way to get the automatix Fixes: <bugno> in *vc-log* like we
> had for bzr?

AFAICS, it Just Works by default?
(Thanks to log-edit-rewrite-fixes in dir-locals.el.
The only difference is that Fixes: is not converted to --fixes,
since git doesn't have that, but passed unchanged into the commit log.)



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-16  1:46 ` Glenn Morris
@ 2014-11-16  4:35   ` Stefan Monnier
  2014-11-16 19:30     ` Glenn Morris
  2014-11-16  9:28   ` Jan D.
  1 sibling, 1 reply; 13+ messages in thread
From: Stefan Monnier @ 2014-11-16  4:35 UTC (permalink / raw)
  To: Glenn Morris; +Cc: Jan D., emacs-devel

> (Thanks to log-edit-rewrite-fixes in dir-locals.el.
> The only difference is that Fixes: is not converted to --fixes,
> since git doesn't have that, but passed unchanged into the commit log.)

FWIW, I'm not convinced this counts as "it just works".  It looks pretty
ugly (more ugly than a "(bug#NN)" somewhere in the commit message).
I'd rather have it moved to the end of the commit message, for example.


        Stefan



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-16  4:35   ` Stefan Monnier
@ 2014-11-16 19:30     ` Glenn Morris
  2015-01-06 20:55       ` Glenn Morris
  0 siblings, 1 reply; 13+ messages in thread
From: Glenn Morris @ 2014-11-16 19:30 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Jan D., emacs-devel

Stefan Monnier wrote:

> FWIW, I'm not convinced this counts as "it just works".  It looks pretty
> ugly (more ugly than a "(bug#NN)" somewhere in the commit message).
> I'd rather have it moved to the end of the commit message, for example.

Maybe you should have asked for that to be dealt with before allowing
the transition then. But I'm sure someone will quickly respond to your
request now.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-16 19:30     ` Glenn Morris
@ 2015-01-06 20:55       ` Glenn Morris
  0 siblings, 0 replies; 13+ messages in thread
From: Glenn Morris @ 2015-01-06 20:55 UTC (permalink / raw)
  To: emacs-devel


Re: http://lists.gnu.org/archive/html/emacs-devel/2014-11/msg01090.html

>> FWIW, I'm not convinced this counts as "it just works".  It looks pretty
>> ugly (more ugly than a "(bug#NN)" somewhere in the commit message).
>> I'd rather have it moved to the end of the commit message, for example.

Any takers for this?
(Making log-edit move "Fixes: xxx" for git to the end of the commit message.)



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-16  1:46 ` Glenn Morris
  2014-11-16  4:35   ` Stefan Monnier
@ 2014-11-16  9:28   ` Jan D.
  2014-11-16 19:29     ` Glenn Morris
  1 sibling, 1 reply; 13+ messages in thread
From: Jan D. @ 2014-11-16  9:28 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel


> 16 nov 2014 kl. 02:46 skrev Glenn Morris <rgm@gnu.org>:
> 
> "Jan D." wrote:
> 
>> Is there a way to get the automatix Fixes: <bugno> in *vc-log* like we
>> had for bzr?
> 
> AFAICS, it Just Works by default?
> (Thanks to log-edit-rewrite-fixes in dir-locals.el.
> The only difference is that Fixes: is not converted to --fixes,
> since git doesn't have that, but passed unchanged into the commit log.)

Is this a local addition you have?  There is no such thing in my unmodified .dir-locals.el:

 (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
                   (log-edit-setup-add-author . t)))

	Jan D.





^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-16  9:28   ` Jan D.
@ 2014-11-16 19:29     ` Glenn Morris
  2014-11-16 20:17       ` Eli Zaretskii
  2014-11-16 20:31       ` Jan D.
  0 siblings, 2 replies; 13+ messages in thread
From: Glenn Morris @ 2014-11-16 19:29 UTC (permalink / raw)
  To: Jan D.; +Cc: emacs-devel

"Jan D." wrote:

>> AFAICS, it Just Works by default?
[...]
> Is this a local addition you have?  There is no such thing in my unmodified .dir-locals.el:
>
>  (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
>                    (log-edit-setup-add-author . t)))

Hmph, the bzr and git versions differ!?

http://git.savannah.gnu.org/cgit/emacs.git/tree/.dir-locals.el
http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/.dir-locals.el

Someone can now have fun figuring out what Hideous Problem this signifies..,



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-16 19:29     ` Glenn Morris
@ 2014-11-16 20:17       ` Eli Zaretskii
  2014-11-16 20:31       ` Jan D.
  1 sibling, 0 replies; 13+ messages in thread
From: Eli Zaretskii @ 2014-11-16 20:17 UTC (permalink / raw)
  To: Glenn Morris; +Cc: jan.h.d, emacs-devel

> From: Glenn Morris <rgm@gnu.org>
> Date: Sun, 16 Nov 2014 14:29:45 -0500
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
> "Jan D." wrote:
> 
> >> AFAICS, it Just Works by default?
> [...]
> > Is this a local addition you have?  There is no such thing in my unmodified .dir-locals.el:
> >
> >  (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
> >                    (log-edit-setup-add-author . t)))
> 
> Hmph, the bzr and git versions differ!?
> 
> http://git.savannah.gnu.org/cgit/emacs.git/tree/.dir-locals.el
> http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/.dir-locals.el
> 
> Someone can now have fun figuring out what Hideous Problem this signifies..,

None whatsoever.  Try "git log -n1 .dir-locals.el", and see for
yourself.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-16 19:29     ` Glenn Morris
  2014-11-16 20:17       ` Eli Zaretskii
@ 2014-11-16 20:31       ` Jan D.
  2014-11-17  2:09         ` Glenn Morris
  1 sibling, 1 reply; 13+ messages in thread
From: Jan D. @ 2014-11-16 20:31 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

Paul Eggert removed it at 584fa315db2c041f0e05a9d709c3ee03c7f91be2.

       Jan D.



> 16 nov 2014 kl. 20:29 skrev Glenn Morris <rgm@gnu.org>:
> 
> "Jan D." wrote:
> 
>>> AFAICS, it Just Works by default?
> [...]
>> Is this a local addition you have?  There is no such thing in my unmodified .dir-locals.el:
>> 
>> (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
>>                   (log-edit-setup-add-author . t)))
> 
> Hmph, the bzr and git versions differ!?
> 
> http://git.savannah.gnu.org/cgit/emacs.git/tree/.dir-locals.el
> http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/.dir-locals.el
> 
> Someone can now have fun figuring out what Hideous Problem this signifies..,

[-- Attachment #2: Type: text/html, Size: 1916 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-16 20:31       ` Jan D.
@ 2014-11-17  2:09         ` Glenn Morris
  2014-11-17  3:45           ` Paul Eggert
  0 siblings, 1 reply; 13+ messages in thread
From: Glenn Morris @ 2014-11-17  2:09 UTC (permalink / raw)
  To: Jan D.; +Cc: Paul Eggert, emacs-devel

"Jan D." wrote:

> Paul Eggert removed it at 584fa315db2c041f0e05a9d709c3ee03c7f91be2.

IMO that was a mistake, it should have stayed (just delete the comment).




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fixes: in vc for git?
  2014-11-17  2:09         ` Glenn Morris
@ 2014-11-17  3:45           ` Paul Eggert
  0 siblings, 0 replies; 13+ messages in thread
From: Paul Eggert @ 2014-11-17  3:45 UTC (permalink / raw)
  To: Glenn Morris, Jan D.; +Cc: emacs-devel

Glenn Morris wrote:
> IMO that was a mistake, it should have stayed (just delete the comment).

Sure, that's fine.  I don't use log-edit-mode myself, I was just trying to guess 
how others use it, incorrectly as it turns out.



^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2015-01-06 20:55 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-14  7:37 Fixes: in vc for git? Jan D.
2014-11-14 13:59 ` Eric S. Raymond
2014-11-14 18:41   ` David Caldwell
2014-11-16  1:46 ` Glenn Morris
2014-11-16  4:35   ` Stefan Monnier
2014-11-16 19:30     ` Glenn Morris
2015-01-06 20:55       ` Glenn Morris
2014-11-16  9:28   ` Jan D.
2014-11-16 19:29     ` Glenn Morris
2014-11-16 20:17       ` Eli Zaretskii
2014-11-16 20:31       ` Jan D.
2014-11-17  2:09         ` Glenn Morris
2014-11-17  3:45           ` Paul Eggert

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).