From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Thu, 08 Apr 2021 08:48:56 +0000 Message-ID: <9ff81b52fad2911cc740@heytings.org> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <878s5wmsjp.fsf@mail.linkov.net> <87mtubz4ls.fsf@mail.linkov.net> <8735w22s9b.fsf@mail.linkov.net> <3ec7e2e58a3733a48ae9@heytings.org> <878s5tc0rn.fsf@mail.linkov.net> <3ec7e2e58a49d4f0ec99@heytings.org> <878s5t9p1i.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11847"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ergus , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 08 10:50:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUQMR-0002wF-N5 for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Apr 2021 10:49:59 +0200 Original-Received: from localhost ([::1]:41488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUQMQ-0003Vh-Oa for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Apr 2021 04:49:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUQLa-0002bB-92 for emacs-devel@gnu.org; Thu, 08 Apr 2021 04:49:07 -0400 Original-Received: from heytings.org ([95.142.160.155]:33614) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUQLT-00017F-Ft for emacs-devel@gnu.org; Thu, 08 Apr 2021 04:49:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617871737; bh=3+V0y3Be2AVXCFniJ/GhgRDUK15g5nYPAiDRRmmu2Tw=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=X9bct2SCIvt2iuaKil4YDh1mlEb5EIHWxMyS7c+ZLyB1UHu8JUYF6Pr+NTFPV3IAf QEXadJH29Mh/v22ZM2WsJhROoLc5erkJqUeNpeZmCmvWGYn0bSLrp/G+CtimiPEyiS Pqys9D2k4x5nlUKK/zDJIt63XUNH8cX6rbFTXXGd5Wj7rWJOxZqd5Q9iyOKA+UjdRG CXH0wL6gYLsbX0bd4mM0fTkuTv2zW0c+kaPAyPEBFrhujEMZE5L9XA1gwqIijEHiOu XcX1E2/ZNrKcyIxt8Zi7bAndfZa7GxwoDx9L/zsTr8F0841yDO/TGBrxoIpBgNumon vgwYpDKBJKTGQ== In-Reply-To: <878s5t9p1i.fsf@mail.linkov.net> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267600 Archived-At: >> I'm not sure this would work, because it's not always (isearch-repeat >> 'forward). For example with M-v it would be 'backward, regardless of >> the current direction of the search. So I guess it means that another >> symbol property would be necessary. > > A function attached to a symbol could return its search direction. > Indeed, the definitions will be slightly longer, but still this is > better than defining new commands. So this could look like: > > (put 'beginning-of-buffer 'isearch-match-scroll (lambda () (goto-char (point-min))) 'forward) > (put 'end-of-buffer 'isearch-match-scroll (lambda () (goto-char (point-max)) 'backward)) > (put 'scroll-up-command 'isearch-match-scroll (lambda () (goto-char (window-end)) 'forward)) > (put 'scroll-down-command 'isearch-match-scroll (lambda () (goto-char (window-start)) 'backward)) > Thank you! Indeed that should work, I'll try to do that. >> With C-p it's not clear (to me) if it should depend on the current >> direction of the search or not. Should C-s C-p change the direction to >> a backward search, or move to previous line and restart a forward >> search? > > The same question applies to scroll-up-command and scroll-down-command, > e.g. in a forward search using scroll-up-command should change the > direction? > For scroll-up-command and scroll-down-command that would not make sense: it would mean that you start searching at window-end and search backward.