* Re: [Emacs-diffs] master a76420c: Fix emacs-repository-get-version with packed .git
[not found] ` <20160601180344.934D4220153@vcs.savannah.gnu.org>
@ 2016-06-01 19:00 ` Stefan Monnier
2016-06-01 21:16 ` Paul Eggert
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2016-06-01 19:00 UTC (permalink / raw)
To: emacs-devel; +Cc: Paul Eggert
> Parse .git/packed-refs if it exists.
Yuck! Do we really care *that* much about the exact Git revision to get
our hands so dirty? I think we had better just give up if git is
not in PATH.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] master a76420c: Fix emacs-repository-get-version with packed .git
2016-06-01 19:00 ` [Emacs-diffs] master a76420c: Fix emacs-repository-get-version with packed .git Stefan Monnier
@ 2016-06-01 21:16 ` Paul Eggert
0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggert @ 2016-06-01 21:16 UTC (permalink / raw)
To: Stefan Monnier, emacs-devel; +Cc: martin rudalics
[-- Attachment #1: Type: text/plain, Size: 420 bytes --]
On 06/01/2016 12:00 PM, Stefan Monnier wrote:
> Yuck! Do we really care*that* much about the exact Git revision to get
> our hands so dirty? I think we had better just give up if git is
> not in PATH.
I agree with the "Yuck!". The problem is that PATH is empty at that
point, by design. Although I was trying to dodge the need for deeper
surgery, you shamed me into it, so I installed the attached further patch.
[-- Attachment #2: 0001-Avoid-delving-into-Git-internals-for-version.patch --]
[-- Type: application/x-patch, Size: 5296 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-01 21:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160601180344.24543.10599@vcs.savannah.gnu.org>
[not found] ` <20160601180344.934D4220153@vcs.savannah.gnu.org>
2016-06-01 19:00 ` [Emacs-diffs] master a76420c: Fix emacs-repository-get-version with packed .git Stefan Monnier
2016-06-01 21:16 ` Paul Eggert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).