From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: vc-modify-change-comment for "modern" backend fix Date: Thu, 19 May 2022 03:05:30 +0300 Message-ID: <9f1b5ce9-270a-2cb4-d958-f7545fd7d373@yandex.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15507"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Cc: emacs-devel@gnu.org To: "Alfred M. Szmidt" , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 19 02:07:08 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrTh6-0003vZ-I3 for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 02:07:08 +0200 Original-Received: from localhost ([::1]:36834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrTh5-00005y-4n for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 20:07:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrTfd-0007oH-QY for emacs-devel@gnu.org; Wed, 18 May 2022 20:05:37 -0400 Original-Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:37631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrTfb-0004ks-PT; Wed, 18 May 2022 20:05:37 -0400 Original-Received: by mail-wr1-x433.google.com with SMTP id t6so4865419wra.4; Wed, 18 May 2022 17:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=d18yBfXeIa/T8NjJ9bC25FdyeRCuU87REihxNbX6OK0=; b=qLHLYcU3Tw0VJgjdWTjw+Oj8wLxFsoN07dbLhnj+bozG0XyBTwZlPoJSpm1e11Wkhq cAk2PYHfHt+gts3W2+bsM+1Ctd/XdoMtQ0XTDQ0TdpzkkTteuAcUbk6hYIUa1dR3xBok Osr3Qmc6VuEyz/e6Lj7UxMspFdvkIqAVpRUlt6yybQfrYkNXONCvnbBDcLgKl8xGdmYe ywVY2VCDj3cG/N0luI0naGJTOMXEkFQlNQFaLSld3WrkV6uZQ/Z7R5yC7ElaRDSGMD6W nK6B9QF/VRmy6UYbOx8Vv1DqoJQKBN9DaYOJPTu22hL9zgynxZ4kPus40sNZEywUksdv pxwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=d18yBfXeIa/T8NjJ9bC25FdyeRCuU87REihxNbX6OK0=; b=DOc3yniGJoeC/bkx+9SLhlEGpi4KSDU+dUXBS8BMEF63MjSVT5qR4OUdhyZDNwjiQg ujM7g/BLM1Pu/T+NWPVQ21ahwUhN9iUz8Y41lOI7vgxtW3fV6GizK1jq45V/Qwg4xN95 l5s8xmymuh0BY6IXBYFdLZTjLr7JNPg+66WJx+l4Yl9RNmQ0S7taYgx7hChXKPgzpQJ3 J8IWFB2dBehwRwOUmue3xnEuW4LJJ6W5FVhIgiMc09bEGg9T882Z7n2iGYrkibkpb3fQ V2ndipUxx3SIx6WrWrWxg8ZxyRraPyZ2IOSOibMtRsl/DpoSAb42I2XjfoDTxek7iAOf cjHw== X-Gm-Message-State: AOAM530TDJ5CqzVEY/kTRtucjYxdSYHj+MAcxwocPtwE16sv4ehvQfj3 Tuya9vMqyZf3PgxNiDZN/XZmTuAP75A= X-Google-Smtp-Source: ABdhPJxqLOs90WL/a23Oq3dfExHablSDGM9RLHpl7V61CmklzbpIBYSuf/pXpwtFtL/YvXdVTSDCyw== X-Received: by 2002:adf:e505:0:b0:20e:58ce:8cec with SMTP id j5-20020adfe505000000b0020e58ce8cecmr1673403wrm.532.1652918732816; Wed, 18 May 2022 17:05:32 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id bi24-20020a05600c3d9800b00396f8c79d22sm2746749wmb.11.2022.05.18.17.05.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 17:05:32 -0700 (PDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=raaahh@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289944 Archived-At: On 18.05.2022 09:34, Alfred M. Szmidt wrote: > + "Extract the commit message for the current file." > + (vc-call-backend log-view-vc-backend > + 'get-log-entry > + (log-view-current-file) > + (log-view-current-tag))) Why not customize the extraction function only for backends that need it? The backend command could be called 'extract-comment'. Which is somewhat different from "log entry" because the latter seems to include the headers, in VC parlance. And you haven't explained thus far your plan for implementing 'modify-change-comment' for e.g. Git.