[PATCH] Incorrect message in hanja-list-show()

[PATCH] Incorrect message in hanja-list-show()

[Jihyun Cho]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

When the coding system is not UTF-8, the message of 'hanja-list-show'
does not look right.
This problem occurs in most of the the Korean Windows.
The patch is decoding from encoded string by UTF-8.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: emacs-hanja-list-decoding.diff --]
[-- Type: text/x-diff; name=emacs-hanja-list-decoding.diff, Size: 1355 bytes --]

? emacs-hanja-list-decoding.diff
Index: emacs/lisp/language/hanja-util.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/language/hanja-util.el,v
retrieving revision 1.5
diff -u -8 -p -r1.5 hanja-util.el
--- emacs/lisp/language/hanja-util.el	9 Jun 2008 01:18:11 -0000	1.5
+++ emacs/lisp/language/hanja-util.el	23 Jun 2008 16:48:15 -0000
@@ -6541,17 +6541,21 @@ character.  This variable is initialized
         (put-text-property
          (+ 2 (string-match (format "%d\\.[^ ]*" idx) msg))
          (match-end 0)
          'face 'highlight msg)
         (setq char-meaning (cdr (car partial-hanja-list))))
       (setq idx (1+ idx)
             partial-hanja-list (cdr partial-hanja-list)))
     (if char-meaning
-        (setq msg (format "%s   (뜻 : %s)" msg char-meaning)))
+        (setq msg
+              (format "%s   (%s : %s)"
+                      msg
+                      (decode-coding-string "뜻" 'utf-8)
+                      (decode-coding-string char-meaning 'utf-8))))
     (message "%s" msg)))
 
 (defun hanja-list-terminate ()
   "Exit from the hanja listing mode with the currently selected character."
   (let ((base (aref hanja-conversions 0))
         (offset (aref hanja-conversions 1))
         (hanja-list (aref hanja-conversions 2)))
     (throw 'exit-input-loop

Re: [PATCH] Incorrect message in hanja-list-show()

[Jason Rumney]

Jihyun Cho wrote:
> When the coding system is not UTF-8, the message of 'hanja-list-show'
> does not look right.
> This problem occurs in most of the the Korean Windows.
> The patch is decoding from encoded string by UTF-8.
> 

I think the correct patch is to add a coding tag to the file.

Re: [PATCH] Incorrect message in hanja-list-show()

[Jihyun Cho]

2008/6/24 Jason Rumney <jasonr@gnu.org>:
> Jihyun Cho wrote:
>> When the coding system is not UTF-8, the message of 'hanja-list-show'
>> does not look right.
>> This problem occurs in most of the the Korean Windows.
>> The patch is decoding from encoded string by UTF-8.
>>
>
> I think the correct patch is to add a coding tag to the file.
>

I did not think about that. Thank you.