unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jihyun Cho" <jihyun.jo@gmail.com>
To: "Kenichi Handa" <handa@m17n.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Improving hangul input module
Date: Tue, 10 Jun 2008 01:40:19 +0900	[thread overview]
Message-ID: <9d644d9b0806090940k290a2bbcte90cd271e581ddf0@mail.gmail.com> (raw)
In-Reply-To: <E1K5WBS-0004Gv-Dc@etlken.m17n.org>

2008/6/9 Kenichi Handa <handa@m17n.org>:
> In article <9d644d9b0806051257n25d43302p3c2e187fb48e387@mail.gmail.com>, "Jihyun Cho" <jihyun.jo@gmail.com> writes:
>
>> Oh. I don't know that a char-table.
>> I modified a structure of hanja-table and adjusted comments.
>
>> "Maybe" in hangul2-input-method-jaum, hangul2-input-method-moum,
>> hangul3-input-method-cho, hangul3-input-method-jung,
>> hangul3-input-method-jong are deleted. It is checked by a calling
>> function. Therefore, always satisfies the conditions.
>
>> The diff file is too large. So I attached .el files.
>
> I installed them with slight modifications (fix arguments to
> make-char-table, use mapc instead of mapcar, improve several
> docstrings).
>
>> I found a bug.
>> That bug was occurred when the program could not find a character in
>> hanja-table.
>> It was occurring after hanja-table was modified, and I fixed it.
>
> ?? You change is only to hanja-init-load (when to show
> message), and doesn't seem to solve the problem you wrote
> above.
>
> Anyway, please make a diff always with the latest CVS code.

OK. I'm sorry.
The error message is "hanja-filter: Wrong type argument: sequencep,
0", when "(make-char-table 'char-table-extra-slots 0)".
So, I modified "(make-char-table nil)", because hanja-filter's second
argument is list type.




  reply	other threads:[~2008-06-09 16:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-31  8:51 [PATCH] Improving hangul input module Jihyun Cho
2008-06-01 11:24 ` Kenichi Handa
2008-06-03  5:07   ` Kenichi Handa
2008-06-03  7:18     ` Jihyun Cho
2008-06-04 16:14     ` Jihyun Cho
2008-06-05  7:24       ` Kenichi Handa
2008-06-05 19:57         ` Jihyun Cho
2008-06-08  6:24           ` Jihyun Cho
2008-06-09  1:28           ` Kenichi Handa
2008-06-09 16:40             ` Jihyun Cho [this message]
2008-06-10 11:58               ` Kenichi Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d644d9b0806090940k290a2bbcte90cd271e581ddf0@mail.gmail.com \
    --to=jihyun.jo@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=handa@m17n.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).