unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Juri Linkov <juri@linkov.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
	emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>,
	sdsg@amazon.com, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action'
Date: Sun, 2 Jan 2022 19:40:45 +0100	[thread overview]
Message-ID: <9d5f512f-dd10-fb6b-2fe7-db24ed92f7c8@gmx.at> (raw)
In-Reply-To: <86v8z26o15.fsf@mail.linkov.net>

 > This is how we can make customization simpler, helping to get the old behavior
 > back for a set of commands.  Currently there are 11 comint commands that
 > have invocations like:
 >
 >    (pop-to-buffer "*inferior-lisp*" display-comint-buffer-action)
 >    (pop-to-buffer "*scheme*" display-comint-buffer-action)
 >    ...

IIUC 'shell' still has (pop-to-buffer buffer), 'sh-show-shell' has
(pop-to-buffer (process-buffer (sh-shell-process t))).  Shouldn't these
become part of the same scheme?

 > To change their behavior at once the user needs to construct
 > a complex regexp that matches all used comint buffer names,
 >
 >    "\\*inferior-lisp\\*\\|\\*scheme\\*\\|..."
 >
 > This is completely unmanageable.

*eshell*<1>, *eshell*<2> ... come to mind.

 > Instead of this, all calls could add
 > a special tag:
 >
 >    (pop-to-buffer "*inferior-lisp*" '(nil (comint . t)))
 >
 > Then a condition predicate could check for this tag:
 >
 >    (defun display-buffer-comint (buffer-name action)
 >      (assq 'comint action))
 >
 > and the user can customize all comint commands with:
 >
 >    (add-to-list 'display-buffer-alist
 >                 '(display-buffer-comint
 >                   (display-buffer-same-window
 >                    . ((reusable-frames . 0)
 >                       (inhibit-same-window . nil)))))

If we do that we should first make a list of possible tags like 'occur'
or 'info' and check whether we should provide similar functions for them
too.

Yet the problem remains how to easily get back the old behavior for
individual 'display-buffer'-based calls we decided to change.

martin



  reply	other threads:[~2022-01-02 18:40 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org>
     [not found] ` <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org>
2021-12-28 22:37   ` master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Dmitry Gutov
2021-12-28 22:59     ` jakanakaevangeli
2021-12-29  8:17     ` Juri Linkov
2021-12-29 15:00   ` Lars Ingebrigtsen
2021-12-29 16:57     ` Eli Zaretskii
2021-12-30  8:34       ` martin rudalics
2021-12-30  8:47         ` martin rudalics
2021-12-30 10:25           ` martin rudalics
2021-12-30 14:40             ` Stefan Monnier
2021-12-30 17:12               ` martin rudalics
2021-12-30 17:29                 ` Lars Ingebrigtsen
2021-12-30 18:30                   ` martin rudalics
2021-12-31 16:29                     ` Lars Ingebrigtsen
2021-12-31 18:41                       ` martin rudalics
2021-12-30 16:04             ` Juri Linkov
2021-12-30 17:14               ` martin rudalics
2021-12-31 16:47                 ` Sam Steingold
2021-12-31 18:42                   ` martin rudalics
2021-12-31 16:38             ` Sam Steingold
2021-12-31 18:42               ` martin rudalics
2021-12-31 18:55                 ` Sam Steingold
2021-12-31 19:40                   ` martin rudalics
2022-01-03 17:22                     ` Sam Steingold
2021-12-30 17:24           ` Dmitry Gutov
2021-12-30 18:30             ` martin rudalics
2021-12-31 16:28               ` Lars Ingebrigtsen
2021-12-31 18:41                 ` martin rudalics
2022-01-02 16:21                   ` Madhu
2022-01-02 17:09                     ` martin rudalics
2022-01-02 17:43                   ` Juri Linkov
2022-01-02 18:40                     ` martin rudalics [this message]
2022-01-02 20:52                       ` Dmitry Gutov
2022-01-03  7:45                         ` Juri Linkov
2022-01-03 18:21                           ` martin rudalics
2022-01-03 18:38                             ` Stefan Monnier
2022-01-04 10:25                               ` martin rudalics
2022-01-04 15:48                                 ` Stefan Monnier
2022-01-03 21:07                             ` Juri Linkov
2022-01-04 10:26                               ` martin rudalics
2022-01-06 15:30                                 ` martin rudalics
2022-01-06 19:52                                   ` Juri Linkov
2022-01-07 10:36                                     ` martin rudalics
2022-01-07 18:49                                       ` Sam Steingold
2022-01-07 19:03                                         ` Eli Zaretskii
2022-01-07 19:16                                           ` Sam Steingold
2022-01-11 17:20                                       ` Juri Linkov
2022-01-11 18:02                                         ` martin rudalics
2022-01-11 18:15                                           ` Juri Linkov
2022-01-12  8:43                                             ` martin rudalics
2022-01-03  7:51                       ` Juri Linkov
2021-12-29 17:29     ` Sam Steingold
2021-12-29 16:43   ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d5f512f-dd10-fb6b-2fe7-db24ed92f7c8@gmx.at \
    --to=rudalics@gmx.at \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=sdsg@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).