From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 25 May 2021 23:27:36 +0300 Message-ID: <9d551b41-1559-b707-c3c0-61dbb055f148@yandex.ru> References: <87zgwlb4xc.fsf@gmail.com> <87eedxrqz4.fsf@mail.linkov.net> <87r1hviwrw.fsf@gmail.com> <87mtsibwjz.fsf@mail.linkov.net> <87pmxeg19e.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19529"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: Daniel Mendler , emacs-devel@gnu.org, Juri Linkov To: Stefan Monnier , =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 25 22:29:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lldgW-0004ye-RB for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 22:29:52 +0200 Original-Received: from localhost ([::1]:52026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lldgV-0002qD-TQ for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 16:29:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lldeR-0008O8-Ct for emacs-devel@gnu.org; Tue, 25 May 2021 16:27:43 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:51769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lldeP-0006ot-Kg for emacs-devel@gnu.org; Tue, 25 May 2021 16:27:43 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id u133so17434895wmg.1 for ; Tue, 25 May 2021 13:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h3jPujlymfr6MomW59tdGgy1Q2mkb0PKpzp3qANIzdE=; b=RCWZMnDxszKvJJBAQ+JiXIRVp56HLq6s/AcBfLrZDFd8ZtunD6G6GAOJzy7DFa/iI2 YZ6KuQIszRNqDGbxAvyjhacANAecOquzpbYEBz9wdjRe+RDaOXHYucpfxlWg1Y3Z2xcx 9dAMWeVJYJPWCjRItjGq4zI/wuUFTjv2MNHotkfG85e5tcmnlhZ6vFcTQVfdutPf79Ad nj+K3pu7BzKZ8U1mxfzfajqLWCqui1Oj6GpOLnjKcfW03QqTI0yPKZLSZh1oUqDlJB1g Egugph3A6ZaOUd1bFL7zH8BB1U97e1+6Q+yP6LdehMJbS7TI1KaSQ8lbWC6LKFostaLo RaOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h3jPujlymfr6MomW59tdGgy1Q2mkb0PKpzp3qANIzdE=; b=VgcDm7ZSphemXOZ5rpCDsenoNJA+loiylkcXpSOPejzRE/DDPqQx05Pz/pV3KfLQ8N VvdiY3TSJfrYOCsLsT/UVxswxpatXjIaLenNztuRowfifJrqkVsNOx+ZwvF3yCQo+ouK gWVpzOE5NTB0BHRS5cD/UCfc6Jc4u9Tai15uz9tpLL5Fi4ifWn8fBjB5D5HL45pxaJTF xqoGlqk/20ELTE+l+DqqOMweYQrfuIsrJfDHKUBYRjqAROfA+S0HfjnQCRv3RIFV2xH2 UDztG3mKxwIPHzaGSV9/9USycIeL8uLCRwO28pw9pnAVrJUqPx42Bd1B5ZlIcgJM4vgc dw3A== X-Gm-Message-State: AOAM532puQfGBYHjWboHhxzrB+zXyxu15H7Pav4qFxvtaiUiJn3yDipa LB+yTDWvPK+BhHkQ436qcelyFw2hiLM= X-Google-Smtp-Source: ABdhPJzyCo3+rq8MZ9851qtqDgDtkeU9sMt0Ht8092m3k2BSnuYeDN6k1amVEa8t7RV2yLhQ/ajGEQ== X-Received: by 2002:a7b:c114:: with SMTP id w20mr126294wmi.45.1621974459909; Tue, 25 May 2021 13:27:39 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m9sm17167506wrq.78.2021.05.25.13.27.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 13:27:38 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=raaahh@gmail.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269894 Archived-At: On 25.05.2021 23:01, Stefan Monnier wrote: > The fact that it takes a whole list rather than a single element is more > in the "bikeshedcolor" category for me. From where I'm standing, this color of the bike shed would make it harder to use (if I ever found a way to support it in Company, that is). If affixation-function returns a list including extra data, I will then have to convert it to some structure that allows lookup by completion string (e.g. a hash table), and then pass that table on to the place the completions are rendered. display-sort-function is different, because you can use it in one place, have your list re-sorted, and then go on with the rendering of the resulting collection. It doesn't force me to do any extra accounting.