From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [RFE] Migration to gitlab Date: Tue, 19 Mar 2019 16:13:53 +0200 Message-ID: <9c7cf558-a2d3-951e-d6e1-31b3ad5900cf@yandex.ru> References: <1552789070.5272.1@yandex.ru> <1552791707.5272.2@yandex.ru> <1552793646.5272.3@yandex.ru> <1552821396.21432.0@yandex.ru> <83imwhwf4x.fsf@gnu.org> <837ecvux2q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="99786"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 Cc: theophilusx@gmail.com, emacs-devel@gnu.org, hi-angel@yandex.ru To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 19 15:17:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6FYp-000PtG-NM for ged-emacs-devel@m.gmane.org; Tue, 19 Mar 2019 15:17:47 +0100 Original-Received: from localhost ([127.0.0.1]:58055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6FYo-0002w2-IP for ged-emacs-devel@m.gmane.org; Tue, 19 Mar 2019 10:17:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6FXN-0002se-Ma for emacs-devel@gnu.org; Tue, 19 Mar 2019 10:16:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h6FVB-0005RM-HK for emacs-devel@gnu.org; Tue, 19 Mar 2019 10:14:02 -0400 Original-Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:33569) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h6FV8-0005Nu-Vc; Tue, 19 Mar 2019 10:13:59 -0400 Original-Received: by mail-wr1-x441.google.com with SMTP id q1so5685338wrp.0; Tue, 19 Mar 2019 07:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5kfAgKpCMUDl0pTajrFbbmVk7MLkb888VK91wvI2MOU=; b=aC49eH259Km65w717y6cQDJNSJtP02kR6nfgUGsy/fESM9kir3JTmtKCNo7WF2PWW8 2j/MZh48o7OB6UfZj1aaTA2n84Tua9h592fcdV1PySAm07qRobfazFJMdCb5+bB+5ey5 9/ehIuSswNnc4D1q+HVK8/jydH0KSgePoc25kdpPQ1YmAlJBNKgRWlsp/VMvjoJ+0OdZ K40LcrLuOS/7BuPLkPg2zkK5Ionv0DnbSyf70/UocUi11RoIC3AvusMrmiDEL53UKam5 vMz/9m3X53Q9abMyfzLTIpkaghqe8eh/u6Z5Ixar9jlhGQVExL1JGcMWPXYkoar5E9HA 7sww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5kfAgKpCMUDl0pTajrFbbmVk7MLkb888VK91wvI2MOU=; b=GvTkZFYbZzxVIiMxHf3RQq8aWXRFqq+UyOQeTLIBQiI2z/Wl1ENkGwMGCRKkXArPDB e1eG14VSS45s7jYgiW00mHs17BeBE6woa6VoFkmxv23eNXt5jKubjqXgaekF4vJ9Ey+V vdysbTjT6CNK6TapAHIp+Jfx8Rl6oGr/L5i+uA325XzhJv3gaC0NV7OEWKH+4DLgMv4a c39wEbAA4odbx08aGLVt24J13tllPlV5OvzbtReNB2DUgjN1QI0PVRqHoGAq8uIVTOhV F09y/qqal5f2Q7pwbd5qrf1u3kGpf3EsxbYuAiJFS7esm1PL3gqKLpMBqsLelMXZWtz7 TeZg== X-Gm-Message-State: APjAAAV/EatOW7FeopVSB+Dj2QdQZKQEFOtsUxzJ/mVDiUlLd3WZ8ppO VxUCYFJP8WFtzf5t9CI9xLnwUTqA X-Google-Smtp-Source: APXvYqyQVKksP/pALX2axNU4Dy0OqxaVG87QlWdCKmw1f+N586vQicuY3QcmQp/8AwC2+DoTWxun1g== X-Received: by 2002:a5d:6150:: with SMTP id y16mr6763973wrt.13.1553004837107; Tue, 19 Mar 2019 07:13:57 -0700 (PDT) Original-Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id z10sm1527943wml.39.2019.03.19.07.13.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Mar 2019 07:13:55 -0700 (PDT) In-Reply-To: <837ecvux2q.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234367 Archived-At: On 19.03.2019 9:45, Eli Zaretskii wrote: > I suggest you to look up the meaning of "disingenuous" before you use > it. I don't think you really meant that. Apologies for my choice of words (to Savannah admins especially), but the Savannah UI is mostly unused by everybody. And if we're talking about user accounts, they are very minimally used as well (e.g. they could have been be a part of the bug tracker UI). So what's left is a Git server, which is essential, but there are many other available alternatives. Gitlab is a lot more comprehensive and thus unique in its functionality. And people are asking for it because of its UI, for the CI, the repository browsing, and the issue tracker. > In any case, you misunderstood my comment: it was in response to a > claim that Savannah looks like a news site, that's all. I was also indirectly reacting to RMS's replies, I guess. > Again, this is orthogonal to what I was saying, as it takes my > comments out of their context. The issue discussed was the alleged > speed-up of patch contribution process. I think Konstantin was making a point that the PR workflow adds opportunities for a speed-up but doesn't take away anything. And the email workflow would still be available for those who choose it. The mailing lists are unlikely to go away. > Surely, each contributor already knows whether they do or don't have > assignment on file? Of course not. Not every potential contributor anyway. Further, if I'm reviewing a random patch, *I* don't know if the contribution satisfies the CA requirements. If an automatic checking process were available, I could just respond with "Thanks!" and merge. >>> . code submissions should include documentation >>> . commit log messages should be formatted in a certain way >>> . bug numbers should be referenced in log messages >>> . US English conventions in writing comments and documentation >>> (spelling, two spaces between sentences, etc.) >>> . we require copyright assignments for accepting changesets larger >>> than about 15 original source lines >>> . we have peculiar rules regarding the branch were certain changes >>> should be pushed (affects the branch against which contributors >>> should prepare patches) >>> . very elaborate coding and documenting conventions (their >>> description takes around 900 lines in the ELisp manual) >> >> At least some of these checks could be automated on a CI. > > They can also be automated by Git commit hooks. It's just a matter of > someone doing the job. Hooks can help, but if Emacs doesn't even allow one to *commit* a change, it might discourage that person from continuing, or investigating the failed requirement. We can add too many checks to commit hooks. Further, documentation could be in a separate commit, so we can't check for its presence when running hooks for a commit that adds a change. And we can't check for copyright assignment inside a git hook because the information isn't publicly available. > And I didn't say I was against adding CI to Emacs, that wasn't at all > the intent of my comments. I just wanted to make the issue more > complete and balanced, because it isn't as clear-cut as the OP seemed > to indicate in the original message. I think the core message is sound. He said "easier", not "easy": """ migrating to gitlab should make contributions easier for bigger part of the open-source world, peoples who used to github and gitlab """ I agree with that.