From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 7) Date: Thu, 20 May 2021 20:51:44 +0200 Message-ID: <9c4c09a1-b197-8c73-0517-a1826eff7922@daniel-mendler.de> References: <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> <87r1ifpyuc.fsf@mail.linkov.net> <83eeef7nzh.fsf@gnu.org> <87eeed2l0q.fsf@mail.linkov.net> <83o8dh3ybw.fsf@gnu.org> <854d8dbc-b64c-77e1-843b-95ac19e230e2@daniel-mendler.de> <83h7j93wjg.fsf@gnu.org> <83a6p13uux.fsf@gnu.org> <83fsyq2ab4.fsf@gnu.org> <87fsyhb8b4.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14543"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 20 20:52:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljnmo-0003dE-Us for ged-emacs-devel@m.gmane-mx.org; Thu, 20 May 2021 20:52:46 +0200 Original-Received: from localhost ([::1]:49534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljnmn-0000fd-J9 for ged-emacs-devel@m.gmane-mx.org; Thu, 20 May 2021 14:52:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljnlx-0008Nb-CC for emacs-devel@gnu.org; Thu, 20 May 2021 14:51:53 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:55317 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljnlu-00077O-OO; Thu, 20 May 2021 14:51:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IxwQ5Q8z+qp//pXUpJ57HX9jj93pCWp+HeqZaPHvZfk=; b=H42JQU3x5sTicSM901EQOqza/u s9WeqLUBqEEgPCzOLajp2G0HJ3M8jYvNgmP9nlkVyfqTLnEGXvJ9zr0e0M/7tzO26EKlcJolPUbG3 RUhHE9gLuij5KsQKZMYuzpbHsLIlmuncKzYq0tqgsNWEL7YbJXRnBYHnrEhfCkYbHwd0=; In-Reply-To: <87fsyhb8b4.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269508 Archived-At: On 5/20/21 7:53 PM, Juri Linkov wrote: > I tried out again, and everything works without problems. Thank you! > > Since there are no more objections, it seems the version 7 of your patch > is the final version, so I pushed it to master. Thank you for merging and thank you all for the discussion and improvement proposals! I pushed the corresponding changes to my packages which now use the official `group-function`. I just compiled Emacs master and everything works as expected. Daniel