From: Dmitry Gutov <dgutov@yandex.ru>
To: "Juan José García-Ripoll" <juanjose.garciaripoll@gmail.com>,
emacs-devel@gnu.org
Subject: Re: Error in project-shell?
Date: Sat, 19 Mar 2022 04:14:23 +0200 [thread overview]
Message-ID: <9c209fe6-da39-4a5c-cadf-f8b5d9bc371e@yandex.ru> (raw)
In-Reply-To: <861qz2vsh3.fsf@csic.es>
Hi again,
On 16.03.2022 17:15, Juan José García-Ripoll wrote:
> I have been doing further tests and I think that the actual definition
> should read as follows
>
> (defun project-shell-fix ()
> "Fixed version for project-shell"
> (interactive)
> (require 'comint)
> (let* ((default-directory (expand-file-name (project-root (project-current t))))
> (default-project-shell-name (project-prefixed-buffer-name "shell"))
> (shell-buffer (get-buffer default-project-shell-name)))
> (if (comint-check-proc shell-buffer)
> (pop-to-buffer shell-buffer (bound-and-true-p display-comint-buffer-action))
> (shell (or shell-buffer default-project-shell-name)))))
>
> The change in the last line is needed, because otherwise the shell is
> created with the wrong name.
Could you describe what happens in more detail? Which wrong name?
And what about other changes? The version you showed differs from the
current code in more than just the last line.
prev parent reply other threads:[~2022-03-19 2:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 14:58 Error in project-shell? Juan José García-Ripoll
2022-03-02 2:30 ` Dmitry Gutov
2022-03-02 7:59 ` Juan José García-Ripoll
2022-03-05 2:34 ` Dmitry Gutov
2022-03-16 15:15 ` Juan José García-Ripoll
2022-03-19 2:14 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c209fe6-da39-4a5c-cadf-f8b5d9bc371e@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=juanjose.garciaripoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).