From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: master ca47390: image-dired: Report when a necessary executable is not found Date: Mon, 5 Sep 2016 00:42:23 -0400 Message-ID: <9ba96760-15da-e7f5-a4e5-4a93ecd49f7a@gmail.com> References: <20160904134431.30494.94659@vcs.savannah.gnu.org> <20160904134431.7513F220140@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O1wjoeMhqNnugB4D0SGpP96I23Iwhcjp1" X-Trace: blaine.gmane.org 1473050572 31778 195.159.176.226 (5 Sep 2016 04:42:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Sep 2016 04:42:52 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 05 06:42:49 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bglk8-0007iN-2x for ged-emacs-devel@m.gmane.org; Mon, 05 Sep 2016 06:42:48 +0200 Original-Received: from localhost ([::1]:52251 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bglk4-0004AB-Pi for ged-emacs-devel@m.gmane.org; Mon, 05 Sep 2016 00:42:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgljy-0004A0-GU for emacs-devel@gnu.org; Mon, 05 Sep 2016 00:42:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgljt-0007Y4-Gk for emacs-devel@gnu.org; Mon, 05 Sep 2016 00:42:37 -0400 Original-Received: from mout.kundenserver.de ([217.72.192.74]:54727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgljt-0007Xz-5y for emacs-devel@gnu.org; Mon, 05 Sep 2016 00:42:33 -0400 Original-Received: from [18.189.118.169] ([18.189.118.169]) by mrelayeu.kundenserver.de (mreue103) with ESMTPSA (Nemesis) id 0MW8Zl-1baKcw0oRd-00XNM2 for ; Mon, 05 Sep 2016 06:42:31 +0200 In-Reply-To: X-Provags-ID: V03:K0:hdibigSln9sWxRntg/SaeRHlvmHrrtZZjQAb+frVoCKCTHucOjB 3d5UWlUe3FWcfMGI4XQOHGNJmZRpfr3HzigjrVuNxh8Qs8rmIGJTqcozm6x7mTPtPuFtCDx F7gONAxhef03U2TaAXYqLtsepAcHuCeKX0fkbAa408QPdPw4bH2Kf9o3kCxciJs7ZIVQgiB L0FaVzo/EQr0aYN2Mrp6w== X-UI-Out-Filterresults: notjunk:1;V01:K0:4up2Bw/19jE=:7RLMo78nQZy+zQnxZrx6DP HslbRqYSJkCnBgMEW7BbU/d9CRUhPJq4gnrT6jmdeWsLqfUMDDD/gsbl9/C1aAk7/koFoXwBo fehzxX3z9xPV3Arzmsop+BZAPeTyxW7s68Lk4jgPQ6PCGtUJvHkHPNz00qCp0nb9NbqkQnm30 tmpxh4/fu8X9PmVrxk+UFU0I5jY4aBpBE22dm8s8ncvXbPJUWTwjwnDRm9hSFFYkL0oS4DArK LYfRVLR1rJ1sRwk9ysXwYkAtq2bZ2tFoPZBxWrCcfs4V0Zi9tfV2xIhpATLqm0l8b6fAFxcWd 5QXfCqeIkhs2Z+2ATzsJAkWPRdWmo0ZLoOHr6+pjdvH+Rp8pEOxkinxEZmTYm+8aAZdiuyE97 UQyzVF5VV0YBAndsp3ZYJW0DBkq6XyFqHDEYovgJfcKa9HAxckC4OxttdTCG/RToiCaLAX1s3 r6SVM6Z/hg/Q5itl4Iwf+wFtOsVDLsik5bjfVTBR5PFX41QNn5G/YJA1f24aPEpmeqvcRGCNu wSX4OtmI5u4aJH0gzTsnqtPGsGoNTdNH/hoS7WcxkZ9DrRWYVcIQiFgij3VjH0KJpEy6o1o4w OoiwWjOUcRibnJUbnJ7q8aX85aYpv1H+FnEUEwKGwTrKdeITvbSwxEIQVMUJu1bN/pCNOsyN4 Cc0XPQjkPbLk5navU7689j98fW4hR/Ib3SL9UhlkF4wJgc4CKSswVnGZnPFFicpJRNqY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.74 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207187 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --O1wjoeMhqNnugB4D0SGpP96I23Iwhcjp1 Content-Type: multipart/mixed; boundary="p46Xv2fnH40qGlspSSBRq1geRFrnFRpHh"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: emacs-devel@gnu.org Message-ID: <9ba96760-15da-e7f5-a4e5-4a93ecd49f7a@gmail.com> Subject: Re: master ca47390: image-dired: Report when a necessary executable is not found References: <20160904134431.30494.94659@vcs.savannah.gnu.org> <20160904134431.7513F220140@vcs.savannah.gnu.org> In-Reply-To: --p46Xv2fnH40qGlspSSBRq1geRFrnFRpHh Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2016-09-04 23:42, Tino Calancha wrote: > Please let me know if the following patch is OK: > =85 > (defcustom image-dired-cmd-create-thumbnail-program > - "convert" > + (executable-find "convert") > =85 > (defcustom image-dired-cmd-create-thumbnail-program > - (executable-find "convert") > + (when (executable-find "convert") "convert") I don't understand how these two consecutive patches works. Assume I don= 't have "convert". Before the patches Emacs would complain, and installin= g ImageMagick would fix the complaint. After, Emacs will complain about = not finding "convert", but after I install ImageMagick Emacs will keep co= mplaining, because the defcustom will still be nil. Is this intended? O= r am I misunderstanding something? Cheers, Cl=E9ment. --p46Xv2fnH40qGlspSSBRq1geRFrnFRpHh-- --O1wjoeMhqNnugB4D0SGpP96I23Iwhcjp1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXzPe0AAoJEPqg+cTm90wj9doP/A9Hu0S2Jak6XwoQtk1VWfC2 jrcVWWycljjBcm8LYIWuN8oTnktgh7e9bV4Nle2MLmf3V90pTiV6uC5uL4BMOzkF nMD5WDNMZuwkAsX+8sunhILUlqlT+ArLPtI3HUxv8TIf8AN7KMDotTQ5XYVAIMtv bP58kXPhqqHDYnX2F3sVXnye1gkpHKk4z/hbdYPB6TGYj0ulqaMsZt4qKOXlCKFm uzw/TzB8ACR75usU0qp3cKikmDHGI5Nn4S6x2YFoEVuhG7+NOwjH7TIq6KdwWJYQ JSXxYflVWTwr7ZO24M35nlv2u3V1oDzRpq2fES3rOF6lxI8ZOt/ZZyjbQMKmHNKk WQWCR+58J6RrY2N6ToudzcY2QfznSPCQi3bHoFsnbPNGZal0e1X8itPrERLAm1d6 IoNa8KU7CPONiLy7y+ud09fdoseW39gBXknUfaVV2lJvv3k65g1e6E9Cp8y4XWnN 8px83l02/GBPKQLx8ZKAAGNlc3KEZXQlIZ873ecSQy8MuPGzWcjB8ZqRnrmcF7Ed BQsFBktvQogeUeN6Q+c7/FmEei59zsJg7jXSqfuFFla6Za8jwTf9/KhpubsBL8V7 Nthn2+KgR/zG4DrpAwHZaq2bUNz2ibDHd6Ca2cj5EpzQ2eSimQ3pjHDYDVP340Y0 yuodGymRCw3iwwDWwGi+ =Z30l -----END PGP SIGNATURE----- --O1wjoeMhqNnugB4D0SGpP96I23Iwhcjp1--