From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Adding support for xref jumping to headers/interfaces Date: Sat, 11 Nov 2023 22:54:20 +0200 Message-ID: <9b51885d-50ae-f72f-16fa-f877928d7c36@gutov.dev> References: <65a16247-1b1a-149c-b413-71612f88f184@yandex.ru> <9377bf2b-13ed-8d86-4294-0b88e6808d80@yandex.ru> <953056ea-9cfb-34ad-6515-9036633dfdbb@yandex.ru> <2d964697-2b4e-64c7-2f16-aae87e57def4@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17295"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Spencer Baugh , emacs-devel@gnu.org To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 11 21:55:03 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1v0P-0004Hq-LN for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Nov 2023 21:55:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1uzs-00066M-A3; Sat, 11 Nov 2023 15:54:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1uzp-00065r-9f for emacs-devel@gnu.org; Sat, 11 Nov 2023 15:54:25 -0500 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1uzn-0007id-NH for emacs-devel@gnu.org; Sat, 11 Nov 2023 15:54:24 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 446E85C010C; Sat, 11 Nov 2023 15:54:23 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sat, 11 Nov 2023 15:54:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1699736063; x=1699822463; bh=82htjrfSO9smQaQ7h9g32jv9ENjmX57Izf6 pR0ap0d8=; b=NRv802Hi2iKgMG0NJWBtVOWHdg2yj/XmzQHc6q062aKgjWYpVnp Q73eSQYi94TEQVzkBMselIfH6ll0xCCwIcMUXYVp7YYznI2+07c+6gNlDpL2PN3+ AbB0A5yr4lLRFP2tx60fS8wZ/+bxFP/woZQwCONVEk/zLJQL1BC9HWJchrbqleeG qBVFTY35u+IcAgpjsZUdurcHWuJaxtnB8xKw4HmxPePPLy/Ijp5irVTNmwb8XBXh plEfRVeTpLHawO1O9ZfPsyIF2Yfl+p+ftXEPhmPrpu9fb3FUSaaxNfllCisGq9TA Pig/RYcGViPoFI1pXK50Qtt4J2c9W6e6qtA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699736063; x=1699822463; bh=82htjrfSO9smQaQ7h9g32jv9ENjmX57Izf6 pR0ap0d8=; b=U7gxePgv5IC1Is957dc3FuZGMwprvxLYcEeG96gjGH0HaoCOXfj grSSjgFG2eK8kTs4+LtQBhOwxJFDQpVmEBASH6KiwtQ5NmvjeKw6+uoptI3MHpNH AKXbaCbYH3r9QklEAMtdrTjTBZ1R+TwqSVZ2ckR/q8hliJiUHpWTjnUIStiZzuto ux7uJnIjBhJCitgnGzKikHGikMgH2wB2YhLbMAd6KTRV7Uwhlc9LSLvkYuPAZN0/ 84ZZYYRXr0UDu2wGtZ6YjkoKfjoUQ9hBZWpAHQvY++r3wn8qKC1MFrqYrO5U1SIp 0qmWFJ4DxayxJwbvXyQhHvLM4RCRlY4QwaA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvhedgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpefhffehleejffegffeugefhkeektdffgfehjedvgeejtedtudehueffgffg feejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 11 Nov 2023 15:54:21 -0500 (EST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=66.111.4.29; envelope-from=dmitry@gutov.dev; helo=out5-smtp.messagingengine.com X-Spam_score_int: -69 X-Spam_score: -7.0 X-Spam_bar: ------- X-Spam_report: (-7.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-4.148, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312612 Archived-At: On 11/11/2023 13:22, João Távora wrote: >>>> Is that possible? >>> For Dmitry to answer >> >> FWIW, the above is one of the alternatives that I had in mind when I >> mentioned obsoleting the said commands. >> >> The other alternative looked like this, though: >> >> (make-obsolete 'eglot-find-declaration "use `xref-find-extra'" "...") >> (make-obsolete 'eglot-find-implementation "use `xref-find-extra'" "...") >> (make-obsolete 'eglot-find-typeDefinition "use `xref-find-extra'" "...") > > No, I'm not obsoleting those commands, sorry. Not least because > new LSP things may come along that xref.el won't be able to respond > in time with. So those commands are staying there. So what if that happens? You'll add the new commands to Eglot then. Just like any other backend is supposed to do if they support commands not in the built-in set. > The "declaration/implementation/typeDefinition" triplet is an LSP > invention and Eglot is for LSP, so eglot- commands they will be, > even if sometimes later in an eglot-commands.el file along with > other ones. And that's even if we do import that LSP invention > into xref (which I think we shouldn't -- see my reply to Spencer). Eglot is not the only LSP client for Emacs. I think there are about 4 of them at the moment...? Each with their own command definitions.