From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Should (buffer-list) ever return killed buffers? Date: Mon, 24 May 2021 16:15:29 +0200 Message-ID: <9b005615-9b52-cc9c-e620-bc87334f08e0@gmx.at> References: <87wnrpujo0.fsf@osv.gnss.ru> <87bl91uhn0.fsf@osv.gnss.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5232"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Sergey Organov , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 16:16:29 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llBNd-0001FP-GG for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 16:16:29 +0200 Original-Received: from localhost ([::1]:45566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llBNa-0005X7-Lu for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 10:16:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llBMq-0004pw-G9 for emacs-devel@gnu.org; Mon, 24 May 2021 10:15:40 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:41161) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llBMn-0003CV-6X for emacs-devel@gnu.org; Mon, 24 May 2021 10:15:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1621865731; bh=bKovMG29ScxkajV/3JLopvi8fmHTNe1t2Y3BtdtnxM4=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=ZysFVeJWrWUzwcmLHXgV21Gj573vBbw3Xa30NJ737hGt9Gdvmtrj4MWU/k7cBwq8L I5L/SRUnzmnwkObIHZp1TzYpDXu8Cpsy4dmJuF3k11+nOKeiTbldIMpZTS1N6h00nq zNXfJE3cq2dAnjPFlWv4GMRJo2sSBM0wTlRntU4o= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.177]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MUXpK-1lu15P0EsK-00QS17; Mon, 24 May 2021 16:15:31 +0200 In-Reply-To: <87bl91uhn0.fsf@osv.gnss.ru> Content-Language: en-US X-Provags-ID: V03:K1:+IA6gZ+eGewRPFOQTATRCUsEACF72Jbt4W5a4/kxSd3LvOyDpjP DUGsl0YpO19/M6uDyYZI5svvPN6WixxPAcr3HIPPqMtWgKF7GcEQ1mMtV0cGC+WEuR3dNcW NP4++6LsJmgdzANlANejOj3Sw5i2FToaoeSx7RduE6OTccSzDhBf1UXrmiWa/9sdMcWW2CX ECMKso5egrh1aD57dObuA== X-UI-Out-Filterresults: notjunk:1;V03:K0:MoHwlwBLUdc=:pk2NKOiLx4v6IV1Y2oEOls E/I1J49mLncSZhJUXHEJgEXdA1rCd44L9yRvPM2y8qb20jM4LU1/CskXSjdY6LPXYAXjxgf5k MQLgwX1x0lJtHy1gYizRRmXC1SsYz1PeUhdK9+4hORyA4uHd0wx2JFpejyDcdHmJl11S71Xsk iSL3ecMd0Wes1NLJAR3sA0jxsTL4AzwxAAAOIckbGbq/jNz4mDjTvb1UF3qO/8kou3G6QFq+E e1NJSbGMgluMdQQKiiUKsr9Qrlo7EpfihxCQXKnRsoBtc0ivQrfyMsVMCLimdqT2qE19h+z+E f39SlvKDz0N1HQ3bgnw9NOVAbWRfvPb8bMW0rdfyKdO+xi+pXQfq2DDr5p6y1OG3tVN7dOiMS a9e1Y9H1N0INf9ZDfhr9bRW/GvU9EPxsJ3DfMFk0DMDe2IjpUKKRNX261e9Nnxsw98GMliF4A 4rW4GO8Ac7GyvJpgbq2vIJcd8XYwli1P4cDtxM5HYD+04HPoXVu+vMiZeVZbqOo6iZ5TVoTCy XX42Y3tSFpn4316hWW/rta2BKHrA+ohB80YUTyfowkuf3PyYjDTQ1OvGy+fK+zvJAuaqdvBDl KLFW1vN4mWdNcvOXrfE7hWMAjPZvEscwQZsL/Dga+UOgYGHZu8zPV30ROev7DK8+Vo+0DXECt BOvO0yx8M4nejMmfHRgawhiCDWMTfNi2VKgqFoJEATYNYsVXnPIsx5cJh+BB/JEbG5Gmx2Gw4 fNA1Y2ryHE9VHHa1RsWfxJdDQSqkKnToy0+LBU1zP3nYtYFrOUNyMBM6SRo2+IWsHsQVxzE2 Received-SPF: pass client-ip=212.227.15.19; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269757 Archived-At: >> I strongly suspect that the problem goes as follows: >> - buffer-list returns a list of buffers that are all live (i.e. no bug >> there). I strongly doubt that. For me the reason is that `buffer-list' runs FOR_EACH_TAIL_INTERNAL with third argument true which may quit. The earlier mentioned "And how running from a timer could be involved?" should explain what happens then. >> - while processing that list, some of its buffers die. >> So I think the bug is in `desktop-clear` which should skip buffers that >> have died between the call to `buffer-list` and the moment we get to >> process them. We should fix `buffer-list' appropriately. IIUC it's broken anyway with a non-nil FRAME argument - it nowhere checks whether the buffers on FRAME's buffer list and buried buffer list are live. > + (unless (or (nill bufname) ^^^^ martin