From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: jixiuf Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Fri, 2 Oct 2020 12:45:41 +0800 Message-ID: <9E48A84B-C05F-4C63-B775-70357788DD17@139.com> References: <20200912133311.6ujtgczj6wyclufy@Ergus> <20200920130435.heye7bk73pm252km@Ergus> <83sgbczj0i.fsf@gnu.org> <83lfh4zfml.fsf@gnu.org> <838sd4z6lz.fsf@gnu.org> <20201001164804.mqqyxtet4ttweuyv@Ergus> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_E81E63CC-C469-4D43-AF97-5F036694F341" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22449"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 02 06:47:50 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOCz0-0005j8-7L for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Oct 2020 06:47:50 +0200 Original-Received: from localhost ([::1]:44322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOCyz-0006Ic-9z for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Oct 2020 00:47:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOCxL-0005od-TY for emacs-devel@gnu.org; Fri, 02 Oct 2020 00:46:08 -0400 Original-Received: from n9-20.mail.139.com ([221.176.9.20]:46402) by eggs.gnu.org with smtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kOCxG-0002LE-GC for emacs-devel@gnu.org; Fri, 02 Oct 2020 00:46:07 -0400 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Original-Received: from [192.168.173.17] (unknown[114.255.108.162]) by rmsmtp-rmapp-01-12001 (RichMail) with SMTP id 2ee15f76b07345e-1a68a; Fri, 02 Oct 2020 12:45:48 +0800 (CST) X-RM-TRANSID: 2ee15f76b07345e-1a68a In-Reply-To: <20201001164804.mqqyxtet4ttweuyv@Ergus> X-Mailer: Apple Mail (2.3608.120.23.2.4) Received-SPF: pass client-ip=221.176.9.20; envelope-from=jixiuf@139.com; helo=n9-20.mail.139.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/02 00:45:49 X-ACL-Warn: Detected OS = Linux 2.6.x [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256921 Archived-At: --Apple-Mail=_E81E63CC-C469-4D43-AF97-5F036694F341 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > 2020=E5=B9=B410=E6=9C=882=E6=97=A5 =E4=B8=8A=E5=8D=8812:48=EF=BC=8CErgus= =E5=86=99=E9=81=93=EF=BC=9A >=20 > Hi: >=20 > I made some corrections to simplify the icomplete-vertical feature > branch and pushed (forced) some days ago. (sorry for that, I should = have > used a scratch branch instead) >=20 > Now the icomplete-format variable is removed and the user only needs = to > add at least one '\n' to the separator. I also use > window-text-pixel-size to correct the issue with long lines but still > perform the height calculations in pixels to properly show the = ellipsis > as Eli recommended. >=20 > I keep the funcall approach because IMO it is cleaner, and reduces > unneeded and redundant things. (And because it is compatible with > something else I am working in) >=20 > If some of the previous testers could give it a second try. When it is > fine I will add some documentation and merge in master. I have tried your branch and it worked perfectly.=20 1. And Is there any plan to implements a completion style like helm or = orderless(https://github.com/oantolin/orderless = ). Divides the pattern into space-separated components, and matches = candidates that match all of the components in any order. 2. And Is there any plan to implements async-completing-read for = icomplete , one of my use cases involve an external command to generate the list of = candidates,=20 and that command may take some time to run( like conusel-rg). Hope those feature can be implemented in emacs core.=09 >=20 > BTW: If someone could give a look to the completions-highlight feature > branch too and make recommendations, report issues? >=20 > Best, > Ergus >=20 --Apple-Mail=_E81E63CC-C469-4D43-AF97-5F036694F341 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

2020=E5=B9=B410=E6=9C=882=E6=97=A5 =E4=B8=8A=E5=8D=8812:48=EF=BC= =8CErgus <spacibba@aol.com> =E5=86=99=E9=81=93=EF=BC=9A

Hi:
I made some corrections to simplify the = icomplete-vertical feature
branch and pushed (forced) some = days ago. (sorry for that, I should have
used a scratch = branch instead)

Now the icomplete-format = variable is removed and the user only needs to
add at = least one '\n' to the separator. I also use
window-text-pixel-size to correct the issue with long lines = but still
perform the height calculations in pixels to = properly show the ellipsis
as Eli recommended.

I keep the funcall approach because IMO it is = cleaner, and reduces
unneeded and redundant things. (And = because it is compatible with
something else I am working = in)

If some of the previous testers could = give it a second try. When it is
fine I will add some = documentation and merge in master.
I have tried your branch and it = worked perfectly. 

1. And Is = there any plan to implements  a completion style like helm or =  orderless(https://github.com/oantolin/orderless).
 Div= ides the pattern into space-separated components, and matches candidates = that match all of the components in any order.

2. And Is there any plan to = implements async-completing-read for icomplete = ,
 one of my use cases involve an external command to = generate the list of candidates, 
and that command may = take some time to run( like conusel-rg).

Hope those feature can be implemented in emacs = core. =



BTW: If someone could give a look to the = completions-highlight feature
branch too and make = recommendations, report issues?

Best,
Ergus


= --Apple-Mail=_E81E63CC-C469-4D43-AF97-5F036694F341--