From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Call for volunteers: add tree-sitter support to major modes Date: Tue, 11 Oct 2022 08:41:58 +0200 Message-ID: <9E2D0EEB-3910-4C58-96E7-68E7C84E5097@thornhill.no> References: <83czb1jrm3.fsf@gnu.org> <878rlo7on0.fsf@thornhill.no> <83o7uki5ol.fsf@gnu.org> <87tu4c5g9j.fsf@thornhill.no> <835ygshz6k.fsf@gnu.org> <87zge3jj0j.fsf@gnus.org> <83o7uig9dm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8365"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, emacs-devel@gnu.org, jostein@kjonigsen.net To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 08:44:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oi90E-0001wn-Gu for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 08:44:34 +0200 Original-Received: from localhost ([::1]:38424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oi90D-0007gz-CD for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 02:44:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi8xx-0006rg-Tq for emacs-devel@gnu.org; Tue, 11 Oct 2022 02:42:13 -0400 Original-Received: from out2.migadu.com ([2001:41d0:2:aacc::]:53929) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi8xv-0003AB-IW; Tue, 11 Oct 2022 02:42:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1665470526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zKqYjeJ5ZcY5Pu5LfqgGGBD9h1VzQTWR1zVys50b/s4=; b=JeH/GkOcaym3TVPlDLNvGJwn3FmAdLDjgmQIzCs+C+AuVvpuNrxJ9Jb+rpeyX0Q8tPd4hk 610Dwnw6lJcakUFSjTR1jyOBO9blVayPYkeqxY5izDXCerG60Y7MEIt8qHCuB1MfZDmjQL 7xXJBXpdZlUXXeRBtlfTwJv2IeqsrwSYW6PREMAMnRTvUK/pONxFplRQcWG7Udc147UhiM 5qMAeez87eOe7SAS9tsFvYAHBv+yFwMYVrEvOxQzVvAir75MD3z8yIGlWn5O1hx1C/vm5s TGH6eTyrIPnhrMhuomhXJyOLeWm5My+YCLLJFcqkDxqvA/ai4lCmNSc7fPHGUQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <83o7uig9dm.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=theo@thornhill.no; helo=out2.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297424 Archived-At: On 11 October 2022 08:30:29 CEST, Eli Zaretskii wrote: >> From: Lars Ingebrigtsen >> Cc: Theodor Thornhill , acm@muc=2Ede, >> emacs-devel@gnu=2Eorg, jostein@kjonigsen=2Enet >> Date: Tue, 11 Oct 2022 02:34:04 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> >> My suggestion is to add the tree-sitter variant in these cases, and = let >> >> the other modes die a slow, deprecated death down the line=2E >> >>=20 >> >> What do you think? >> > >> > SGTM, but I'd like to hear from Lars as well=2E >>=20 >> It's somewhat confusing that we have some modes that are tree-sitter-on= ly >> and some what can switch between using tree-sitter and not, but I guess >> that's inevitable=2E > >We could arrange for a very minimal font-lock without tree-sitter >(like, for example, only strings and comments?), and use the defaults >for the indentation commands=2E Theodor, can that be done with a >relatively small effort? Yes, we could actually just delegate that work to vanilla js-mode, as Type= script is just a superset of Javascript=2E That would mean we would get the= benefits of that lineage, but missing some more advanced highlights etc=2E= =20 What do you think?=20 > >> But I think the in-tree tree-sitter typescript-mode will have to be >> called something else than the out-of-tree non-tree-sitter one, at >> least=2E > >That's desirable, yes=2E Sure, I can rename it to tsx-mode, because that's the parser being used=2E= Why is that desirable, though?=20 Theodor