From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Sat, 22 Jan 2022 17:06:47 +0100 Message-ID: <9D116A4B-622F-4C80-83E6-2CDD7ED9AD25@acm.org> References: <83mtjwzwkb.fsf@gnu.org> <87r198ytog.fsf@gnus.org> <87zgnvyb5y.fsf@gnus.org> <87bl03j10s.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11769"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Mackenzie , Eli Zaretskii , Stefan Monnier , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 22 17:10:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBIyK-0002rC-TH for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 17:10:36 +0100 Original-Received: from localhost ([::1]:45044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBIyJ-0004Ln-Bl for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 11:10:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBIuv-0003Tv-Id for emacs-devel@gnu.org; Sat, 22 Jan 2022 11:07:05 -0500 Original-Received: from mail1475c50.megamailservers.eu ([91.136.14.75]:49276 helo=mail118c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBIun-0000kX-T5; Sat, 22 Jan 2022 11:07:00 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1642867611; bh=dQsvZUndjNRavfzS+3CoUZKWBLyXH/RI5mNGFqOBSu8=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=gfwsWmrd+RlrY1wyoIZ7Sh+KlVCEHyL4AgjOs1h9hz0jMepWvu7M/UkVgFBFheMeH 5r2DRyk1IVyXelHi/w7BT0uGq4jOvlhnDj2mOWOtLAj5rUQWPt7rZFhJKboRIt383D DswTcN6pGLnwhGd26n7OYoTaaO4kGeVghJXNhVU8= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 20MG6mDI017180; Sat, 22 Jan 2022 16:06:49 +0000 In-Reply-To: <87bl03j10s.fsf@gnus.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F18.61EC2B9A.0054, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.14.75; envelope-from=mattiase@acm.org; helo=mail118c50.megamailservers.eu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285216 Archived-At: 22 jan. 2022 kl. 15.30 skrev Lars Ingebrigtsen : >> I now propose to merge the branch into master. Do you (or anybody = else) >> still have any issues with this? >=20 > I'd like to see the results from elisp-benchmarks with and without = this > patch set, please. In my experience, the elisp-benchmarks are very much not representative = of actual elisp usage, and I have done quite some benchmarking for other = reasons lately. Unless Alan has improved scratch/correct-warning-pos significantly in = the last few days, it still exhibits a penalty of about 3 % over master = on common code that I've tried. Byte-compilation is even slower than = that since it enables symbol positions. It all depends a lot, of course -- obviously code that spends all its = time in I/O, in GC or the regexp engine will see little difference.