unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org
Subject: Re: vc-mode-line ancient, root-specific code for buffer-read-only
Date: Tue, 18 Dec 2018 22:16:50 -0800	[thread overview]
Message-ID: <999b7b9b-4c91-a517-4c65-b88998fe3b6f@cs.ucla.edu> (raw)
In-Reply-To: <irtvjam87w.fsf@fencepost.gnu.org>

Glenn Morris wrote:
> 
> I would like to suggest just removing that vc-mode-line code.
> It's for locking VCS, is buggy, and doesn't even make sense.
> root cannot "write anything", unless we are concerned with odd cases
> like a file being writable by other but not owner. Ie locked files would
> be marked read-only for root anyway.

The code is indeed for locking VCs which are almost entirely obsolete now. And 
the code has problems if the file has been deleted, as you noted. So I would 
favor removing the code as being more trouble than it's worth.

On the other hand I don't follow the comment "root cannot 'write anything'". 
Traditionally, root can write any file that is writable to any user (and even 
some files that no other users can write to), so in that sense roote can "write 
anything".



  reply	other threads:[~2018-12-19  6:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19  4:49 vc-mode-line ancient, root-specific code for buffer-read-only Glenn Morris
2018-12-19  6:16 ` Paul Eggert [this message]
2018-12-19  9:18   ` Andreas Schwab
2018-12-19 18:10   ` Glenn Morris
2018-12-19 21:23     ` Stefan Monnier
2018-12-19 22:41     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=999b7b9b-4c91-a517-4c65-b88998fe3b6f@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).