From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Patch] Add project.el command to replace symbol at point throughout project Date: Wed, 2 Feb 2022 00:07:46 +0200 Message-ID: <9915e49c-81c9-5a8e-2aa9-a223740231dd@yandex.ru> References: <83zgo2770l.fsf@gnu.org> <83zgo15dhp.fsf@gnu.org> <83czkw3uvl.fsf@gnu.org> <170a1c89-7767-0930-f726-f7b2551876b2@yandex.ru> <44f72f97-d1d8-0b4c-73a0-7f077fb1ef26@yandex.ru> <0617E8BF-CC43-4D82-8648-064252F644FD@gmail.com> <86pmos3no7.fsf@mail.linkov.net> <86czkr36ll.fsf@mail.linkov.net> <921c0b69-7bac-b78a-54d8-987165331661@yandex.ru> <0b8d87f8-e6db-9902-bd89-d81864d626d6@yandex.ru> <861r16235x.fsf@mail.linkov.net> <829a1d78-c07e-4bb8-e3bd-07263271fc30@yandex.ru> <86sft3kbja.fsf@mail.linkov.net> <35a7ae0c-7d9f-4feb-be3b-a93ad4f7a795@yandex.ru> <86a6famjr8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40756"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: Jon Eskin , Eli Zaretskii , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 02 04:17:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nF697-000ASH-AT for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Feb 2022 04:17:25 +0100 Original-Received: from localhost ([::1]:51340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nF695-0003Wh-Qj for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Feb 2022 22:17:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nF1Ja-0008IG-6l for emacs-devel@gnu.org; Tue, 01 Feb 2022 17:07:54 -0500 Original-Received: from [2a00:1450:4864:20::32a] (port=42641 helo=mail-wm1-x32a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nF1JX-0000yu-Fo; Tue, 01 Feb 2022 17:07:53 -0500 Original-Received: by mail-wm1-x32a.google.com with SMTP id n40-20020a05600c3ba800b00353958feb16so2387343wms.1; Tue, 01 Feb 2022 14:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pkxG8U/WLkxRnGxHd7GcNr0G4Npo53KlkCfTWfe4AtM=; b=DqG5Q5am+/+U3XUJB5iU1hJ9U1Tx3WsTkkm3aMd2xlLJ0nUMo7VafGuYuUG89P+K9G zPY97cKqk05urj8npfWTEkaw4Dl4IaCiCLCNLSmPuQnBht/agNe2bBFhIztgGIprhPQv PSeHkRZxh3Ew18OpCgVAuejG+iZOPWl4s6f57/LGpldrIetAeeta/ja34h3SqQmLJbUT pnu1qh0b+F49DRi66B1/w2j/5cYGdyA7PobsPGk6tGyrQwbGU47zwsCnOfDJ9EfW0TwS gI4rT7p6fSBbbD/kAJw2mVsgXghERx5t4jYqqo2Z7h1uwCpBUG9pdjByK5K/voQGWUR0 vljQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pkxG8U/WLkxRnGxHd7GcNr0G4Npo53KlkCfTWfe4AtM=; b=q9Ezjh+4t0k9vNzqSVW/Plq/lHUFtfkaesLzmfbqqigWLBCx7eW8VnAF4ZN2V80N4x ZI6MQhrjKUIYxXmo//S4tpWbnUKqpcO+IK0phRsIRcvYPYBC2m1rmcEJjJ+Pp5QPMVPg 3U+j91/zFehq6+1dEJc+xc1UXoRe2IqY4M1q6Dl3uPTC21HrRYPHvkzs3dDlcbPWYUWV jGtALpZtSTp5PfSf/f09cf1knWEOXDjc2OhVT/VanojvNCNgU69zQu0YJqrG4DMWYqik 7B93yj7G9dPOd3GjWs7GhneVG436vxrOQKZfuUsjdxwD197dYXvfXWcgfjVpd+ShsPwG c8IQ== X-Gm-Message-State: AOAM533arQB2bCXW9P9ontqWWVWpHMafqfkGXPXDoRhrdYTxqwnZmI5D 2kTWdlsFNuef0vwVGZRPc0Q= X-Google-Smtp-Source: ABdhPJygAjgDO5r/GFgmB/jFi2xnKT4TPF65UeiqegFhta7vRKcU8X1cGifA9JpxTUs0C0AIWtjLRQ== X-Received: by 2002:a05:600c:250:: with SMTP id 16mr2177010wmj.47.1643753268676; Tue, 01 Feb 2022 14:07:48 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m11sm2852135wmi.16.2022.02.01.14.07.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Feb 2022 14:07:47 -0800 (PST) Content-Language: en-US In-Reply-To: <86a6famjr8.fsf@mail.linkov.net> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=raaahh@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285763 Archived-At: On 01.02.2022 22:09, Juri Linkov wrote: >>> After thinking more about this, I can't find a possible use for >>> read-string-defaults-function, because every call of read-string >>> provides own default value. Also using read-regexp-defaults-function >>> in query-replace-read-from is not the right thing either - when >>> the users already customized it for e.g. occur, it would be too >>> unexpected when it will use a tag at point instead of from->to >>> pairs in query-replace. >>> Since query-replace is a very special command, the most uncontroversial >>> thing to do for a conservative approach would be to add two specific >>> variables (that later could be turned into options when needed): >> Sounds reasonable, thanks. >> >> If you're satisfied with the change, please go ahead and install the >> patches. > So now patches are installed in master. Thanks! Could you try testing the new behavior in xref-find-references-and-replace? I'm seeing this: - If there are no entries in history, I see the appropriate text in the first prompt (featuring the tag near point), but when I press RET, the next prompt which should mention the thing to replace, just has two spaces in a row. And indeed, the behavior is as if it's read an empty string. - If there are history entries, and I press RET (to use the default FROM), it proceeds to do a search right away instead of prompting me for TO. And it uses the from-to pair from history instead of the current input. project-query-replace-regexp seems all right, OTOH.