unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Alan Mackenzie <acm@muc.de>, emacs-devel@gnu.org
Subject: Re: How about making `set-minibuffer-window' obsolete?
Date: Wed, 17 Mar 2021 09:44:37 +0100	[thread overview]
Message-ID: <98c16576-39b8-2f34-e9f5-4f5c04c28dcd@gmx.at> (raw)
In-Reply-To: <YFD2A3cnEDSa3DM4@ACM>

 > Does anybody have any objection to me making set-minibuffer-window
 > obsolete?
 >
 > It's defined in src/minibuf.c, but not used by any C function, and it's
 > not used by any Lisp in Emacs itself - the nearest to a use is a
 > commented out occurrence in lisp/textmodes/ispell.el.
 >
 > This function just sets the C variable minibuf_window.  This variable is
 > defined (by comment) to be the minibuffer window of the selected frame.
 > So setting it to a random mini-window will cause nasty problems.
 >
 > Actually, I'd prefer just to remove the function entirely - but there's
 > always the chance it's being used by some external library.
 >
 > So, any objections?

Rather `set-minibuffer-window' should take as argument a frame to set
the 'minibuffer-window' parameter of that frame.  This way it would
become the counterpart of `minibuffer-window' which takes as argument a
frame and returns that frame's minibuffer window.

The current semantics of `set-minibuffer-window' is of no practical use.
Lisp code should never deal with minibuf_window directly.  However,
every minibuffer interaction should be aware of the fact that any
frame's minibuffer window might change via fset_minibuffer_window under
its feet.

martin



  parent reply	other threads:[~2021-03-17  8:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 18:16 How about making `set-minibuffer-window' obsolete? Alan Mackenzie
2021-03-16 18:42 ` Eli Zaretskii
2021-03-16 20:50   ` Alan Mackenzie
2021-03-17 12:57     ` Eli Zaretskii
2021-03-18 11:46       ` Alan Mackenzie
2021-03-18 12:01         ` Eli Zaretskii
2021-03-16 19:42 ` [External] : " Drew Adams
2021-03-16 23:04   ` Alan Mackenzie
2021-03-16 23:00 ` Stefan Monnier
2021-03-16 23:24   ` Alan Mackenzie
2021-03-17  3:31   ` Eli Zaretskii
2021-03-17  8:44     ` martin rudalics
2021-03-16 23:17 ` Dmitry Gutov
2021-03-16 23:28 ` Stefan Monnier
2021-03-17  8:44 ` martin rudalics [this message]
2021-03-17 13:17   ` Eli Zaretskii
2021-03-17 15:36     ` martin rudalics
2021-03-17 15:45       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98c16576-39b8-2f34-e9f5-4f5c04c28dcd@gmx.at \
    --to=rudalics@gmx.at \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).