Re: master 72ec233: Ignore pending_signals when checking for quits.

Re: master 72ec233: Ignore pending_signals when checking for quits.

[Glenn Morris]

> branch: master
> commit 72ec233f2a1b8a6a9574e61588d0467caf41755c
[...]
>     Ignore pending_signals when checking for quits.

Hi,

This causes a test failure on hydra.nixos.org, and also for me on RHEL 7.6:

Ref: https://hydra.nixos.org/build/89511758

  data/emacs-module/mod-test.c:32:22: fatal error: timespec.h: No such
     file or directory #include "timespec.h"

Does test/Makefile.in need -I$(srcdir)/../lib adding to MODULE_CFLAGS?
Even after such a change, I get

  ../src/emacs: symbol lookup error:
  /path/to/test/data/emacs-module/mod-test.so: undefined symbol: dtotimespec

Re: master 72ec233: Ignore pending_signals when checking for quits.

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

On 2/25/19 2:05 PM, Glenn Morris wrote:
> Ref: https://hydra.nixos.org/build/89511758
I reproduced that problem on Fedora 29 and fixed it by installed the
attached patch. Not sure it's the best way to fix it, but at least now
the test works for me.

[-- Attachment #2: 0001-Fix-mod-test-build-failure.patch --]
[-- Type: text/x-patch, Size: 1638 bytes --]

From b5ebfbfdee2d486269f6ad5c57f27edbb1d919b7 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@Penguin.CS.UCLA.EDU>
Date: Mon, 25 Feb 2019 17:44:46 -0800
Subject: [PATCH] Fix mod-test build failure

Problem reported by Glenn Morris in:
https://lists.gnu.org/r/emacs-devel/2019-02/msg00739.html
* test/Makefile.in (HYBRID_MALLOC, LIBEGNU_ARCHIVE):
New macros, taken from ../src/Makefile.in.
(MODULE_CFLAGS): Add -I$(srcdir)/../lib.
($(test_module)): Link $(LIBEGNU_ARCHIVE) too.
---
 test/Makefile.in | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/test/Makefile.in b/test/Makefile.in
index 4eddb676d4..ce6ce04b8b 100644
--- a/test/Makefile.in
+++ b/test/Makefile.in
@@ -254,17 +254,21 @@ FPIC_CFLAGS =
 FPIC_CFLAGS = -fPIC
 endif
 
+HYBRID_MALLOC = @HYBRID_MALLOC@
+LIBEGNU_ARCHIVE = ../lib/lib$(if $(HYBRID_MALLOC),e)gnu.a
+
 # Note: emacs-module.h is generated from emacs-module.h.in, hence we
 # look in ../src, not $(srcdir)/../src.
-MODULE_CFLAGS = -I../src $(FPIC_CFLAGS) $(PROFILING_CFLAGS) \
+MODULE_CFLAGS = -I../src -I$(srcdir)/../lib \
+  $(FPIC_CFLAGS) $(PROFILING_CFLAGS) \
   $(WARN_CFLAGS) $(WERROR_CFLAGS) $(CFLAGS)
 
 test_module = $(test_module_dir)/mod-test${SO}
 src/emacs-module-tests.log: $(test_module)
-$(test_module): $(test_module:${SO}=.c) ../src/emacs-module.h
+$(test_module): $(test_module:${SO}=.c) ../src/emacs-module.h $(LIBEGNU_ARCHIVE)
 	$(AM_V_at)${MKDIR_P} $(dir $@)
 	$(AM_V_CCLD)$(CC) -shared $(CPPFLAGS) $(MODULE_CFLAGS) $(LDFLAGS) \
-	  -o $@ $<
+	  -o $@ $< $(LIBEGNU_ARCHIVE)
 endif
 
 ## Check that there is no 'automated' subdirectory, which would
-- 
2.20.1

Re: master 72ec233: Ignore pending_signals when checking for quits.

[Philipp Stephani]

Am Di., 26. Feb. 2019 um 02:47 Uhr schrieb Paul Eggert <eggert@cs.ucla.edu>:
>
> On 2/25/19 2:05 PM, Glenn Morris wrote:
> > Ref: https://hydra.nixos.org/build/89511758
> I reproduced that problem on Fedora 29 and fixed it by installed the
> attached patch. Not sure it's the best way to fix it, but at least now
> the test works for me.

Thanks. Not sure why this worked locally for me without that change.

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat
sind, leiten Sie diese bitte nicht weiter, informieren Sie den
Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank.

This e-mail is confidential. If you are not the right addressee please
do not forward it, please inform the sender, and please erase this
e-mail including any attachments. Thanks.