From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: src/nsterm.m: fix window tabbing on macOS Date: Sun, 6 Jun 2021 22:19:57 +1000 Message-ID: <9814156B-6B84-4CFA-9F5F-A1B05F19826F@bydasein.com> References: <4cf0b73bcefc7d159881d368b3a4b7f5@purelymail.com> <228099F1-BAB6-4E3A-AD0F-FB4282817CEB@bydasein.com> <83mts3ikoa.fsf@gnu.org> <2C0F466D-0FEB-439B-8049-D8EA5FC0B21B@bydasein.com> <8CCF969D-32AF-4542-8838-21DF4AA45523@yasufuku.dev> Reply-To: "Paul W. Rankin" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32044"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Naofumi Yasufuku , Eli Zaretskii , emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 06 14:21:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lprmP-00081F-Cv for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Jun 2021 14:21:25 +0200 Original-Received: from localhost ([::1]:42644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lprmO-0005u6-DU for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Jun 2021 08:21:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lprlc-0004nJ-6E for emacs-devel@gnu.org; Sun, 06 Jun 2021 08:20:36 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:45284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lprlW-0005Vu-Md for emacs-devel@gnu.org; Sun, 06 Jun 2021 08:20:35 -0400 DKIM-Signature: a=rsa-sha256; b=y6pyFJb8S2gaoP8QWZY8uJSIk1OyjQsfqbMeeSiOfcZCK10kUdvglGFKp/E/3Ik6y22D1A6Cs6S4S0QP8HlMzW6ZgjwoV4+dLhDij168aJ9ps6Y03TABqkyMXhfi8W4zRqZOTdIUogHT7zLlEqCY24/6NVniKx+ktcs7Dir/o9sHMKV37VacfddWry2ZEI96JYwPPIZDCDe61xRe/ebOCwyToflS/ci7ma2qenJx3UyuUrCPluaLE4oapK+/BW5b3/McZiJphIoGbSrhhLcz3knTpTFcc/jVvcSxykw+UDwqIoAzF9Mm0Vk9r3OknacAMaDqpzM2axBJ1RFFO7Ki8A==; s=purelymail3; d=bydasein.com; v=1; bh=pm6s0piZYv0zapDsLTTd8Zcp1nGZcy4Df0U8yxFH0nk=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=vewmsRLshYCXTfptLiwKlEnPx681g4gnKnlWlXpWoXtHFNp//RGDPYM2Fl7s+c8dyYMsFstEefdudUei6nNKFaRPGGnVw87bnoNF4p/qW/UjJAvxmAEPUtlQ0cFa4RwrU6ygIHVi/oOuMtte14yhVgqXfhe4cWxgs1PESBODbOfKkag27PLa7TAx+R1aGorKvr5dJysovloGiggO7aTvArlkKg1AV30lo5jfieMr6PciUsJ4JaunZNPfHi+KdjkZlSoaxz6+S/Y0dGpCeqOQI956Gv3lb0sjSh0d9zHKkP+uxJrIj+C9ygvHQ5pP1tS5lEporSn5kS5VFgKAMeV3cQ==; s=purelymail3; d=purelymail.com; v=1; bh=pm6s0piZYv0zapDsLTTd8Zcp1nGZcy4Df0U8yxFH0nk=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by ip-172-30-0-124.ec2.internal (JAMES SMTP Server ) with ESMTPA ID -1661257019; Sun, 06 Jun 2021 12:20:05 +0000 (UTC) In-Reply-To: X-Mailer: Apple Mail (2.3654.100.0.2.22) Received-SPF: pass client-ip=34.202.193.197; envelope-from=pwr@bydasein.com; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270477 Archived-At: > On 6 Jun 2021, at 9:36 pm, Alan Third wrote: >=20 > On Sun, Jun 06, 2021 at 07:07:53PM +0900, Naofumi Yasufuku wrote: >>=20 >> I found the following issues with this macOS native tab commit. >> Does anyone else encounter the same problems? >>=20 >> 1) Frame height increases (even if frame-inhibit-implied-resize is = t). >> attachment: >> 01_macOS-tab-issue-increases-height.gif >> 01_macOS-tab-issue-increases-height-2.gif =E2=80=A6 (sets = frame-inhibit-implied-resize t) >=20 > Strangely I don't see this. The frame stays the same height... Alan did you see my video of this in action? https://f002.backblazeb2.com/file/pwr-share/emacs_nsterm.mov >> 2) New tab name is =E2=80=98emacs=E2=80=99 instead of buffer name. >> (even if C-x 5 C-f `find-file-other-frame=E2=80=99) >> attachment: >> 02_macOS-tab-issue-odd-tab-name.gif >=20 > It turns out that when multiple NSViews are put into one NSWindow > using tabs, AppKit doesn't bother telling all the views to update > themselves when the window changes, it appears to only message the > currently visible one. This is a problem. >=20 > The tab name issue can be sorted with this change: > ... Interestingly this only happens with tool-bar-mode on. With eamcs -Q = (tool-bar-mode 0) new frames/tabs get the correct name. Which makes me = wonder if it's another case of some code somewhere interfering? >> 3) Tabs are not shown in fullscreen. >> attachment: >> 03_macOS-tab-fullscreen-expected-textedit.gif. .. e.g. macOS Test = Edit app >> 03_macOS-tab-issue-fullscreen-emacs.gif Yeah we're considering this a separate nice-to-have, right?