unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master f56408a: * lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete.
       [not found] ` <20211026081719.E1D3721011@vcs0.savannah.gnu.org>
@ 2021-10-26  8:48   ` Dmitry Gutov
  2021-10-26  8:56     ` Mattias Engdegård
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2021-10-26  8:48 UTC (permalink / raw)
  To: emacs-devel, Mattias Engdegård

On 26.10.2021 11:17, Mattias Engdeg�rd wrote:
>      * lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete.

Why not?



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master f56408a: * lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete.
  2021-10-26  8:48   ` master f56408a: * lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete Dmitry Gutov
@ 2021-10-26  8:56     ` Mattias Engdegård
  2021-10-26  9:35       ` Dmitry Gutov
  0 siblings, 1 reply; 4+ messages in thread
From: Mattias Engdegård @ 2021-10-26  8:56 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: emacs-devel

26 okt. 2021 kl. 10.48 skrev Dmitry Gutov <dgutov@yandex.ru>:

>>     * lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete.
> 
> Why not?

It felt small-minded to generate obsoletion warnings for external packages that now have to make their code uglier in order to avoid that if they are particulate about a clean CI, especially if they compile with byte-compile-error-on-warn (which I often do).

The warning doesn't tell them anything useful; the semantics haven't changed. This is in contrast to the variables made obsolete.

Does this reasoning make sense? I could revert the change.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master f56408a: * lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete.
  2021-10-26  8:56     ` Mattias Engdegård
@ 2021-10-26  9:35       ` Dmitry Gutov
  2021-10-26 18:12         ` Mattias Engdegård
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2021-10-26  9:35 UTC (permalink / raw)
  To: Mattias Engdegård; +Cc: emacs-devel

On 26.10.2021 11:56, Mattias Engdegård wrote:
> It felt small-minded to generate obsoletion warnings for external packages that now have to make their code uglier in order to avoid that if they are particulate about a clean CI, especially if they compile with byte-compile-error-on-warn (which I often do).
> 
> The warning doesn't tell them anything useful; the semantics haven't changed. This is in contrast to the variables made obsolete.
> 
> Does this reasoning make sense? I could revert the change.

I don't have a strong opinion about it, but that's how we usually do 
renames: without changing semantics, mark the previous name as obsolete.

I suppose the alternative is to wait for ~6 years until it's reasonable 
to drop support for Emacs 28 in third-party code? And then mark it obsolete?



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master f56408a: * lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete.
  2021-10-26  9:35       ` Dmitry Gutov
@ 2021-10-26 18:12         ` Mattias Engdegård
  0 siblings, 0 replies; 4+ messages in thread
From: Mattias Engdegård @ 2021-10-26 18:12 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: emacs-devel

26 okt. 2021 kl. 11.35 skrev Dmitry Gutov <dgutov@yandex.ru>:

> I don't have a strong opinion about it, but that's how we usually do renames: without changing semantics, mark the previous name as obsolete.

You are probably right. I'll revert to marking the old name obsolete, unless someone comes with a strong argument for not doing so.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-26 18:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20211026081718.30075.27468@vcs0.savannah.gnu.org>
     [not found] ` <20211026081719.E1D3721011@vcs0.savannah.gnu.org>
2021-10-26  8:48   ` master f56408a: * lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete Dmitry Gutov
2021-10-26  8:56     ` Mattias Engdegård
2021-10-26  9:35       ` Dmitry Gutov
2021-10-26 18:12         ` Mattias Engdegård

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).