unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Issues running gitmerge
Date: Mon, 21 Aug 2023 18:28:03 -0700	[thread overview]
Message-ID: <98016d0e-9bb4-55e7-0464-07540a2352b6@gmail.com> (raw)
In-Reply-To: <87sf8banxm.fsf@yahoo.com>

Ok, I've made a couple of changes to fix the merge (see commit 
0df2efa4d69), and then I ran gitmerge successfully and pushed the 
result. Additional details below.

On 8/21/2023 6:03 PM, Po Lu wrote:
> Jim Porter <jporterbugs@gmail.com> writes:
> 
>> The failing files are:
>>
>>    ChangeLog.android
>>      The hook rejects files with ChangeLog in the name, but reports the
>>      wrong error due to a (probable) bug in the hook.
> 
> ChangeLog.android should be kept.  The hook should be fixed.

Fixed.

>>    java/INSTALL
>>      Whitespace "issues" (which are probably non-issues since these are
>>      part of in-line diffs).
>>
>>    java/README
>>      Extraneous newline at the end.
> 
> The hook must be taught to ignore these files.

I've set Git to ignore the whitespace in the former file. Looking more 
closely at the latter, I think the extra newline really is unnecessary, 
so I removed it. However, if I've made a mistake, just let me know.

> I will fix emacs_background.xml.

Thanks.



      reply	other threads:[~2023-08-22  1:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22  0:37 Issues running gitmerge Jim Porter
2023-08-22  1:03 ` Po Lu
2023-08-22  1:28   ` Jim Porter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98016d0e-9bb4-55e7-0464-07540a2352b6@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).