From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Adding battery support on Cygwin
Date: Sat, 13 Jan 2018 13:19:40 -0500 [thread overview]
Message-ID: <97e872b3-e6d2-ec01-80e9-abec35a85c58@cornell.edu> (raw)
In-Reply-To: <83tvvq18lx.fsf@gnu.org>
On 1/13/2018 3:11 AM, Eli Zaretskii wrote:
>> From: Ken Brown <kbrown@cornell.edu>
>> Date: Fri, 12 Jan 2018 21:33:33 -0500
>>
>> The Cygwin-w32 currently supports battery status via the function
>> w32fns.c:Fw32_battery_status. The X11 and nox builds don't have this
>> support, and Cygwin lacks the facilities used on unix-like systems to
>> provide it (/proc/apm, etc.). But it turns out to be easy to compile
>> and use Fw32_battery_status on all Cygwin builds, simply by pulling it
>> out of w32fns.c into a new file.
>>
>> The attached patch does this. OK to push?
>
> Yes, but see some comments below.
Thanks for the review. I've pushed it to master with the changes you
suggested.
Ken
prev parent reply other threads:[~2018-01-13 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 2:33 Adding battery support on Cygwin Ken Brown
2018-01-13 8:11 ` Eli Zaretskii
2018-01-13 18:19 ` Ken Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97e872b3-e6d2-ec01-80e9-abec35a85c58@cornell.edu \
--to=kbrown@cornell.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).