From: JD Smith <jdtsmith@gmail.com>
To: emacs-devel@gnu.org
Subject: Popup-menu signals quit when Aborted
Date: Sat, 1 Feb 2020 09:51:22 -0500 [thread overview]
Message-ID: <97CB42CE-5971-4EA5-B96C-6FA7620DDB74@gmail.com> (raw)
`x-popup-menu` is setup to handle mouse events specially when “aborting” the menu by clicking off of it:
> If the user gets rid of the menu without making a valid choice, for
> instance by clicking the mouse away from a valid choice or by typing
> keyboard input, then this normally results in a quit and
> ‘x-popup-menu’ does not return. But if POSITION is a mouse button
> event (indicating that the user invoked the menu with the mouse) then
> no quit occurs and ‘x-popup-menu’ returns nil.
This seems sensible. But `popup-menu` "normalizes" all incoming positions using `popup-menu-normalize-position`, which strips any mouse event designation in the position before passing it on. So there is no way via `popup-menu` to "indicat[e] that the user invoked the menu with the mouse”. Hence it always quits and ring the bell when the user “gets rid of the menu".
Normalizing away mouse events in this manner seems like a bug in `popup-menu` to me, since `x-popup-menu` explicitly takes mouse events and behaves differently with them.
See https://github.com/tarsius/minions/issues/25 for original discussion.
next reply other threads:[~2020-02-01 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 14:51 JD Smith [this message]
2020-02-01 15:14 ` Popup-menu signals quit when Aborted Eli Zaretskii
2020-02-01 15:55 ` Stefan Monnier
2020-02-01 16:41 ` JD Smith
2020-02-01 16:47 ` Stefan Monnier
2020-02-01 21:58 ` JD Smith
2020-02-01 16:48 ` Eli Zaretskii
2020-02-01 21:58 ` JD Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97CB42CE-5971-4EA5-B96C-6FA7620DDB74@gmail.com \
--to=jdtsmith@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).