From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH) Date: Thu, 29 Apr 2021 19:13:39 +0200 Message-ID: <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8013"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , Dmitry Gutov , "emacs-devel@gnu.org" To: Stefan Monnier , Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 29 19:46:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcAk0-0001yV-2G for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 19:46:20 +0200 Original-Received: from localhost ([::1]:37454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcAjz-0006w7-0y for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 13:46:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcAEa-0001A9-5c for emacs-devel@gnu.org; Thu, 29 Apr 2021 13:13:52 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:45231 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcAEU-0001MN-UI for emacs-devel@gnu.org; Thu, 29 Apr 2021 13:13:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=s4lixmvgrItYO74ZYf7Ishkf1fvU8a6WXwSauCvX1Qk=; b=xlui6M1NJGcA73a9GsXiMvvfon f7HaSDpxsQ7e4DJ7cv5NmOtpily/Qoam1uwLbihgqXQjeokGuJ7DegwYMTEAUVGDqd8LUT6n++7We yGtxxRXgmJa+2hb2Jtg+DT23IyuN9HrWzNUIs1zlL0Nfmi7roFLG1Hh5jMpgv5NxSn68=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268629 Archived-At: On 4/29/21 7:07 PM, Stefan Monnier wrote: > The purpose of the `group-function` when called with a non-nil > `transform` arg is not to *add* text but on the contrary to make the > entries shorter (presumably by removing text shared by all elements of > the group and made redundant by the group name being printed as > a "section title"). > > So the purpose of `affixation/annotation-function` and `group-function` > seem orthogonal (tho we should be careful to make them work together: > the affixation/annotation function will usually need the "full name" in > order to decide what to add, but that the thing should be added to the > text as shortened by `group-function`). Exactly, the grouping and affixation transformation functions are orthogonal and should not be conflated. The patch I provided ensures that the two features work well together - in both cases, with grouping enabled and disabled. Daniel