unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Eli Zaretskii" <eliz@elta.co.il>
Cc: emacs-devel@gnu.org
Subject: Re: supporting more faces on 256 colors xterms
Date: Sat, 14 Feb 2004 14:15:43 +0200	[thread overview]
Message-ID: <9743-Sat14Feb2004141543+0200-eliz@elta.co.il> (raw)
In-Reply-To: <200402132028.i1DKSwY7013278@scanner2.ics.uci.edu> (message from Dan Nicolaescu on Fri, 13 Feb 2004 12:29:00 -0800)

> From: Dan Nicolaescu <dann@ics.uci.edu>
> Date: Fri, 13 Feb 2004 12:29:00 -0800
> 
>   > I think that adding a definition for (min-colors 16) is a Good
>   > Thing regardless, as there's rxvt and a 16-color xterm out there.
> 
> Thanks for the detailed explanations on how these things currently
> work. I have an updated patch. Could you please test it on
> MSDOS/Windows and tell me if the face colors are the same before and
> after my patch? I don't have access to such a machine, so I cannot
> test this myself.

I will try to do this ASAP, but my ASAP might be too long, given my
current lack of free time.

I've proofread your changes, and they seem to be okay.  So if someone
could actually test them on rxvt or a 16-color xterm or on the Windows
console, I think it's okay to go ahead and commit these changes.  Even
if no one tests them, I think they are still okay to commit (unless
others object to these changes); we can always fix later what might
become broken.

> I added separate "min-colors 16" categories everywhere I thought
> they'd be needed. This way it would be easier to change the
> corresponding colors later, if there's a desire to do so. 

An excellent decision, IMHO.  Thanks.

  reply	other threads:[~2004-02-14 12:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-08  4:13 supporting more faces on 256 colors xterms Dan Nicolaescu
2004-02-08  6:08 ` Eli Zaretskii
2004-02-08  8:15   ` Dan Nicolaescu
2004-02-08 13:45     ` Andreas Schwab
2004-02-08 18:24       ` Eli Zaretskii
2004-02-08 19:11         ` Andreas Schwab
2004-02-08 23:19           ` Miles Bader
2004-02-08 23:52         ` Dan Nicolaescu
2004-02-09  6:03           ` Eli Zaretskii
2004-02-12 22:13             ` Dan Nicolaescu
2004-02-13  8:57               ` Eli Zaretskii
2004-02-13 20:29                 ` Dan Nicolaescu
2004-02-14 12:15                   ` Eli Zaretskii [this message]
2004-02-17 20:30                     ` Dan Nicolaescu
2004-02-13  9:02               ` Eli Zaretskii
2004-06-04 19:42               ` Juri Linkov
2004-06-04 21:14                 ` Dan Nicolaescu
2004-06-04 23:12                   ` Juri Linkov
2004-06-05 22:50                 ` Richard Stallman
2004-02-08 18:35     ` Eli Zaretskii
2004-02-09  9:38 ` Richard Stallman
2004-02-12 18:40   ` small grep.el fix Dan Nicolaescu
2004-02-15 13:13     ` Thien-Thi Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9743-Sat14Feb2004141543+0200-eliz@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).