Viper face support on ttys? (Re: viper-color-defined-p)

Viper face support on ttys? (Re: viper-color-defined-p)

[Lőrentey Károly]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

Sorry for the long response time!

IRIE Tetsuya <irie@t.email.ne.jp> writes:
> I have problem if using viper.
>
> 1. emacs -q -nw
> 2. M-x server-start
> 3. M-x viper-mode
> 4. emacsclient -d :0.0&
> 5. some action on X frame (e.g. C-xC-f, M-x foo...)
> 6. viper-save-cursor-color: Symbol's function definition is void: viper-color-defined-p

The error appeared because Viper thinks that Emacs still does not have
support for faces on tty devices.  I committed the following patch as
patch-214, but I think it should also be included in CVS. (The bug is
not triggered in CVS, but the patch enables face support there, too.)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 557 bytes --]

*** orig/lisp/emulation/viper-init.el
--- mod/lisp/emulation/viper-init.el
***************
*** 97,103 ****
  (defun viper-has-face-support-p ()
    (cond ((viper-window-display-p))
  	(viper-force-faces)
! 	(viper-emacs-p (memq (viper-device-type) '(pc)))
  	(viper-xemacs-p (memq (viper-device-type) '(tty pc)))))
  
  \f
--- 97,103 ----
  (defun viper-has-face-support-p ()
    (cond ((viper-window-display-p))
  	(viper-force-faces)
! 	(viper-emacs-p (memq (viper-device-type) '(nil pc)))
  	(viper-xemacs-p (memq (viper-device-type) '(tty pc)))))
  
  \f

[-- Attachment #3: Type: text/plain, Size: 196 bytes --]


2004-07-11  Károly Lőrentey  <lorentey@elte.hu>

        * lisp/emulation/viper-init.el (viper-has-face-support-p):
          Acknowledge that Emacs has face support on ttys.

-- 
Károly

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Viper face support on ttys? (Re: viper-color-defined-p)

[Eli Zaretskii]

> From: lorentey@elte.hu (=?iso-8859-2?Q?L=F5rentey_K=E1roly?=)
> Date: Sun, 11 Jul 2004 00:50:22 +0200
> 
> ! 	(viper-emacs-p (memq (viper-device-type) '(nil pc)))

Actually, this should look at the result of display-color-p.  The
device type alone doesn't cut it, as some tty displays don't support
colors.

Re: Viper face support on ttys? (Re: viper-color-defined-p)

[Richard Stallman]

    > ! 	(viper-emacs-p (memq (viper-device-type) '(nil pc)))

    Actually, this should look at the result of display-color-p.  The
    device type alone doesn't cut it, as some tty displays don't support
    colors.

Would you like to fix it properly?

Re: Viper face support on ttys? (Re: viper-color-defined-p)

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> Date: Sun, 11 Jul 2004 19:23:43 -0400
> 
>     > ! 	(viper-emacs-p (memq (viper-device-type) '(nil pc)))
> 
>     Actually, this should look at the result of display-color-p.  The
>     device type alone doesn't cut it, as some tty displays don't support
>     colors.
> 
> Would you like to fix it properly?

I will look into this in a few days.