From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: Re: Help using the right hook for loading theme on emacs daemon GUI Date: Fri, 25 Jan 2019 14:42:53 +1300 Message-ID: <96a9c5ec62a7325429555fe939392450@webmail.orcon.net.nz> References: <6c1611672809c8d7b5011edf0d2dd831@webmail.orcon.net.nz> <83va2e6t7r.fsf@gnu.org> <83d0ol7scu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="232035"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Orcon Webmail Cc: emacs-devel@gnu.org, kaushal.modi@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 25 02:43:09 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmqWR-000yFb-PN for ged-emacs-devel@m.gmane.org; Fri, 25 Jan 2019 02:43:07 +0100 Original-Received: from localhost ([127.0.0.1]:36666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmqWQ-0005Qs-Nn for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2019 20:43:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmqWL-0005Ql-11 for emacs-devel@gnu.org; Thu, 24 Jan 2019 20:43:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmqWK-00070G-Cn for emacs-devel@gnu.org; Thu, 24 Jan 2019 20:43:00 -0500 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:39867) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmqWI-0006xE-Qs; Thu, 24 Jan 2019 20:42:59 -0500 Original-Received: from [10.253.37.70] (port=36748 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1gmqWD-0003Ib-TJ; Fri, 25 Jan 2019 14:42:54 +1300 Original-Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 25 Jan 2019 14:42:53 +1300 In-Reply-To: X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 60.234.4.43 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232678 Archived-At: On 2019-01-25 10:16, Phil Sainty wrote: > I was already thinking that the `after-make-frame-functions' docstring > could use some additional information (it seems to be a common point > of confusion when people start using --daemon) I forgot to add -- the point I originally thought this docstring needed to make was that FRAME will not be selected when the hook runs, and it is up to the function to select it if required. I'd be inclined to have the docstring suggest that the following be used in that scenario: (with-selected-frame FRAME ...) This is rather more apparent when one looks at the documentation for `make-frame' itself, but people won't necessarily feel the need to do that; and while one can *guess* that this may be the case from the fact that FRAME is being passed to the hook at all, I think it would be better to make it explicit in the hook documentation. -Phil