From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: GtkPlug patch Date: Thu, 5 Jan 2006 11:34:27 +0100 Message-ID: <96DA01D2-EA1B-4739-9DAD-DF8F042621EE@swipnet.se> References: <200601030753.k037rc1o021950@coolsville.localdomain> <85d5j9f99e.fsf@lola.goethe.zz> <8E272012-0E75-4566-A9A6-F2BC92C43440@swipnet.se> <1136441628.8537.15.camel@localhost.localdomain> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (Apple Message framework v746.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1136464823 13102 80.91.229.2 (5 Jan 2006 12:40:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 5 Jan 2006 12:40:23 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 05 13:40:21 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EuUPi-0004gJ-VX for ged-emacs-devel@m.gmane.org; Thu, 05 Jan 2006 13:40:19 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EuUQM-0003s5-M3 for ged-emacs-devel@m.gmane.org; Thu, 05 Jan 2006 07:40:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EuSk0-0006uy-Po for emacs-devel@gnu.org; Thu, 05 Jan 2006 05:53:09 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EuSUQ-00058e-JO for emacs-devel@gnu.org; Thu, 05 Jan 2006 05:37:06 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EuSUN-000583-2j for emacs-devel@gnu.org; Thu, 05 Jan 2006 05:37:00 -0500 Original-Received: from [195.54.107.73] (helo=mxfep02.bredband.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EuSVt-0003cD-RE for emacs-devel@gnu.org; Thu, 05 Jan 2006 05:38:34 -0500 Original-Received: from coolsville.localdomain ([83.226.180.193] [83.226.180.193]) by mxfep02.bredband.com with ESMTP id <20060105103506.YGWR2008.mxfep02.bredband.com@coolsville.localdomain>; Thu, 5 Jan 2006 11:35:06 +0100 In-Reply-To: <1136441628.8537.15.camel@localhost.localdomain> Original-To: Timo Savola X-Mailer: Apple Mail (2.746.2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:48747 Archived-At: > >> But if the author is willing to handle those bug reports, we can put >> this patch in now. It is a very small change, and very safe in that >> it does not alter the normal code path unless you use --parent-id. > > I wonder if this is the case with the emacs-parent-fix.patch. I don't > understand what the code was trying to do, unless it was simply buggy. It is a leftover from older versions. The line your patch removes was the original line. When the test for explicit parent was added, that line was not removed. x_create_tip_frame also has two assignments to parent_desc. Jan D.