From: "Jan D." <jan.h.d@swipnet.se>
Cc: emacs-devel@gnu.org
Subject: Re: GtkPlug patch
Date: Thu, 5 Jan 2006 11:34:27 +0100 [thread overview]
Message-ID: <96DA01D2-EA1B-4739-9DAD-DF8F042621EE@swipnet.se> (raw)
In-Reply-To: <1136441628.8537.15.camel@localhost.localdomain>
>
>> But if the author is willing to handle those bug reports, we can put
>> this patch in now. It is a very small change, and very safe in that
>> it does not alter the normal code path unless you use --parent-id.
>
> I wonder if this is the case with the emacs-parent-fix.patch. I don't
> understand what the code was trying to do, unless it was simply buggy.
It is a leftover from older versions. The line your patch removes
was the original line. When the test for explicit parent was added,
that line was not removed. x_create_tip_frame also has two
assignments to parent_desc.
Jan D.
next prev parent reply other threads:[~2006-01-05 10:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-26 23:09 GtkPlug patch Timo Savola
2005-12-29 7:02 ` Timo Savola
2005-12-31 11:06 ` Jan Djärv
2005-12-31 11:23 ` Jan Djärv
2005-12-31 17:24 ` mr mike
2006-01-01 2:14 ` Richard M. Stallman
2006-01-01 15:57 ` Jan Djärv
2006-01-02 0:25 ` Richard M. Stallman
2006-01-02 9:18 ` Timo Savola
2006-01-02 9:51 ` Timo Savola
2006-01-02 23:48 ` Richard M. Stallman
2006-01-03 8:45 ` Timo Savola
2006-01-03 7:53 ` Jan D.
2006-01-03 18:27 ` Richard M. Stallman
2006-01-03 18:37 ` David Kastrup
2006-01-03 20:29 ` Timo Savola
2006-01-04 6:15 ` Richard M. Stallman
2006-01-04 22:11 ` Jan D.
2006-01-04 22:09 ` Jan D.
2006-01-05 6:13 ` Timo Savola
2006-01-05 10:34 ` Jan D. [this message]
2006-01-03 13:41 ` Lőrentey Károly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96DA01D2-EA1B-4739-9DAD-DF8F042621EE@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).