From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: The emacs-28 release branch has been created
Date: Sun, 3 Oct 2021 17:21:27 -0400 [thread overview]
Message-ID: <96912815-d275-8b54-9ba8-cc4fd5b0fe91@cornell.edu> (raw)
In-Reply-To: <30b78a17-2b95-5d0c-fb46-10c37ee91638@cornell.edu>
On 10/3/2021 3:45 PM, Ken Brown wrote:
> On 10/3/2021 3:20 PM, Eli Zaretskii wrote:
>>> Cc: emacs-devel@gnu.org
>>> From: Ken Brown <kbrown@cornell.edu>
>>> Date: Sun, 3 Oct 2021 13:56:56 -0400
>>>
>>> It turns out that those *.elc files are not in the tarball because of my own
>>> stupid mistake. When I ran make-dist, I got a warning about that. I didn't
>>> want to think about it, so I reran make-dist with --no-check rather than fixing
>>> the problem.
>>
>> Could it be that the *.elc files were not in the tarball because the
>> build failed at some point?
>
> No, they weren't in the tarball because when I built emacs prior to running
> make-dist, I didn't specify --with-native-compilation. Currently
> lisp/Makefile.in has
>
> ifneq ($(HAVE_NATIVE_COMP),yes)
> compile-targets: $(filter-out ./emacs-lisp/comp-cstr.elc,$(filter-out
> ./emacs-lisp/comp.elc,$(TARGETS)))
>
> That seems wrong to me.
>
>> There's still a bug in src/Makefile.in: Make could try building
>> native-lisp even though it exists, because the rules that create that
>> directory don't tell Make the directory is created as a side effect.
>> If and when Make tries to rune the ../native-lisp: rule, it will fail
>> because mkdir will fail.
>
> I see you've fixed that now. I'll test it while building a new tarball.
That fix seems OK. But there are still problems building from a tarball.
First, there's an obvious typo (presumably a copy/paste error) in this part of
the recipe for ../native-lisp:
cp -f $@ $(bootstrap_pdmp)
I assume you want
cp -f $(pdmp) $(bootstrap_pdmp)
if that's even needed at all.
Second, I get the following native-compilation error, which doesn't occur in an
ordinary build (i.e., not from a tarball):
ELN ../lisp/disp-table.eln
Debugger entered--Lisp error: (native-compiler-error "../lisp/disp-table.el"
"Debugger entered--Lisp error: (invalid-read-syntax...")
signal(native-compiler-error ("../lisp/disp-table.el" "Debugger entered--Lisp
error: (invalid-read-syntax..."))
comp--native-compile("../lisp/disp-table.el")
batch-native-compile(t)
eval((batch-native-compile t) t)
command-line-1(("--eval" "(setq load-prefer-newer t)" "-l" "comp" "-f"
"byte-compile-refresh-preloaded" "--eval" "(batch-native-compile t)"
"../lisp/disp-table.el"))
command-line()
normal-top-level()
I'll retry with make -k to see if there are any more such errors, but I might
not get to it until tomorrow.
Ken
next prev parent reply other threads:[~2021-10-03 21:21 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 18:30 The emacs-28 release branch has been created Eli Zaretskii
2021-10-02 15:58 ` Windows Binaries Release: was The emacs-28 release branch Phillip Lord
2021-10-03 10:53 ` Po Lu
2021-10-04 19:04 ` Phillip Lord
2021-10-16 20:24 ` Konstantin Kharlamov
2021-10-17 0:43 ` Po Lu
2021-10-17 13:45 ` Konstantin Kharlamov
2021-10-20 15:26 ` Phillip Lord
2021-10-03 11:22 ` Corwin Brust
2021-10-04 19:05 ` Phillip Lord
2021-10-16 10:03 ` H. Dieter Wilhelm
2021-10-16 13:31 ` Corwin Brust
2021-10-16 16:01 ` H. Dieter Wilhelm
2021-10-20 15:24 ` Phillip Lord
2021-10-20 18:36 ` H. Dieter Wilhelm
2021-10-27 19:36 ` H. Dieter Wilhelm
2021-10-27 21:07 ` Phillip Lord
2021-11-01 20:47 ` H. Dieter Wilhelm
2021-11-01 21:06 ` Óscar Fuentes
2021-11-02 11:16 ` Eshell requires execute permission on Win10, was " H. Dieter Wilhelm
2021-11-02 14:37 ` Óscar Fuentes
2021-11-02 18:57 ` MinGW Sources, was: Windows Binaries Release H. Dieter Wilhelm
2021-11-02 19:07 ` Óscar Fuentes
2021-11-04 17:51 ` H. Dieter Wilhelm
2021-11-08 22:27 ` Phillip Lord
2021-11-09 12:25 ` Eli Zaretskii
2021-11-09 14:32 ` Phillip Lord
2021-11-02 10:47 ` Windows Binaries Release: was The emacs-28 release branch Phillip Lord
2021-11-02 12:05 ` H. Dieter Wilhelm
2021-10-20 15:16 ` Phillip Lord
2021-10-21 0:13 ` Corwin Brust
2021-10-27 21:11 ` Phillip Lord
2021-10-03 1:35 ` The emacs-28 release branch has been created Ken Brown
2021-10-03 6:53 ` Andreas Schwab
2021-10-03 9:27 ` Eli Zaretskii
2021-10-03 15:01 ` Ken Brown
2021-10-03 15:17 ` Eli Zaretskii
2021-10-03 15:34 ` Ken Brown
2021-10-03 16:11 ` Eli Zaretskii
2021-10-03 17:14 ` Ken Brown
2021-10-03 17:33 ` Eli Zaretskii
2021-10-03 17:49 ` Eli Zaretskii
2021-10-03 17:56 ` Ken Brown
2021-10-03 18:03 ` Eli Zaretskii
2021-10-03 19:20 ` Eli Zaretskii
2021-10-03 19:42 ` Eli Zaretskii
2021-10-03 19:45 ` Ken Brown
2021-10-03 21:21 ` Ken Brown [this message]
2021-10-03 22:40 ` Ken Brown
2021-10-04 18:51 ` Eli Zaretskii
2021-10-04 13:31 ` Ken Brown
2021-10-04 14:25 ` Eli Zaretskii
2021-10-04 14:39 ` Eli Zaretskii
2021-10-04 14:45 ` Andrea Corallo via Emacs development discussions.
2021-10-04 14:54 ` Eli Zaretskii
2021-10-04 15:13 ` Andrea Corallo via Emacs development discussions.
2021-10-04 16:15 ` Andrea Corallo via Emacs development discussions.
2021-10-04 16:58 ` Eli Zaretskii
2021-10-04 19:38 ` Andrea Corallo via Emacs development discussions.
2021-10-04 19:40 ` Andrea Corallo via Emacs development discussions.
2021-10-04 19:54 ` Eli Zaretskii
2021-10-04 21:58 ` Ken Brown
2021-10-05 11:43 ` Eli Zaretskii
2021-10-05 15:43 ` Andrea Corallo via Emacs development discussions.
2021-10-05 11:29 ` Eli Zaretskii
2021-10-05 15:37 ` Andrea Corallo via Emacs development discussions.
2021-10-05 16:14 ` Eli Zaretskii
2021-10-05 16:52 ` Andrea Corallo via Emacs development discussions.
2021-10-05 17:12 ` Eli Zaretskii
2021-10-04 11:37 ` Eli Zaretskii
2021-10-04 13:11 ` Ken Brown
2021-10-04 13:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96912815-d275-8b54-9ba8-cc4fd5b0fe91@cornell.edu \
--to=kbrown@cornell.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).