From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Low priority] Some minor complaints from cppcheck about emacs 26.2 Date: Tue, 30 Apr 2019 15:23:18 -0700 Organization: UCLA Computer Science Department Message-ID: <963f59ca-43cc-8748-ec03-7376aa0813f4@cs.ucla.edu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="14184"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: emacs-devel@gnu.org To: Adam Richter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 01 00:24:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLbAP-0003Qw-HT for ged-emacs-devel@m.gmane.org; Wed, 01 May 2019 00:24:01 +0200 Original-Received: from localhost ([127.0.0.1]:54394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLbAO-00034b-Fq for ged-emacs-devel@m.gmane.org; Tue, 30 Apr 2019 18:24:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLb9n-00034V-9U for emacs-devel@gnu.org; Tue, 30 Apr 2019 18:23:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLb9m-0006EB-6i for emacs-devel@gnu.org; Tue, 30 Apr 2019 18:23:23 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52514) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLb9l-0006DQ-Db for emacs-devel@gnu.org; Tue, 30 Apr 2019 18:23:21 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5E4C916186B; Tue, 30 Apr 2019 15:23:19 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id qqcBNmK-PGQm; Tue, 30 Apr 2019 15:23:18 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8B56D1618B9; Tue, 30 Apr 2019 15:23:18 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id S5xPLJEt2ALr; Tue, 30 Apr 2019 15:23:18 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6F2C01617D1; Tue, 30 Apr 2019 15:23:18 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236078 Archived-At: On 4/30/19 2:38 PM, Adam Richter wrote: > lib-src/update-game-score.c <-- I submitted a patch attached to a > message to this mailing list a few minutes ago, which I think fixes > the legitimate complaints. The last complaint ("realloc mistake") > does not appear to be a bug. Since update-game-score is about to exit when the 'free' calls you're proposing would be executed, I'm not sure the changes are that helpful: they complicate the source code and make the executable a tiny bit bigger and slower and don't fix any real leaks. Perhaps if we do full LeakSanitizer checking we can put in the change then, if only to pacify the LeakSanitizer. (It's not clear to me that LeakSanitizer is a win either, as it also reports quite a few false alarms.) > lib/stdint.h <-- This is a real typographical bug and I don't know > what the author intended. There is no lib/stdint.h in the Emacs distribution. On some platforms lib/stdint.h is built from lib/stdint.in.h. If that build process didn't work for you, it sounds like you need need to look into what went wrong in that build process. > > lib/nstrftime.c <-- Possibly a real bug, but only if multibyte is > disabled. A local variable "width", set to -1, is used by a macro > that I think may expect a positive value, but I am not sure of this > fix. I don't see any bug there; could you explain? If 'width' is negative then the macro's _w is zero, which means _n < _w cannot be true (both _n and _w are unsigned), and so the memset calls cannot be invoked. > nt/preprep.c Eli can look into that one if he has the time. > src/regex.c <--I think the tiny memory leak for compile_stack.stack is > real. Is this when MATCH_MAY_ALLOCATE is not defined? If so, let's not worry about it. It's always defined, and the !MATCH_MAY_ALLOCATE code has been removed in Emacs 27.