Re: emacs/lisp/mail rmail.el

Re: emacs/lisp/mail rmail.el

[Glenn Morris]

"Richard M. Stallman" wrote:

> 	(rmail-retry-failure): Discard rmail-ignored-headers.

This change is inconsistent with Emacs 22, and the documentation in
rmail.el and rmail.texi.

If you want this, why not just set your rmail-retry-ignored-headers
equal to rmail-ignored-headers?

Re: emacs/lisp/mail rmail.el

[Richard M Stallman]

    This change is inconsistent with Emacs 22, and the documentation in
    rmail.el and rmail.texi.

The problem has to be fixed.  The behavior as of yesterday is so
inconvenient that I can't believe anyone wants it.

I just looked at the old Rmail code and saw this:

	    (rmail-clear-headers "^sender:\\|^return-path:\\|^received:")

which had got lost.  Would you prefer that fix?

Re: emacs/lisp/mail rmail.el

[Glenn Morris]

Richard M Stallman wrote:

>     This change is inconsistent with Emacs 22, and the documentation in
>     rmail.el and rmail.texi.
>
> The problem has to be fixed. 

What problem?

> The behavior as of yesterday is so inconvenient that I can't believe
> anyone wants it.

In what way? AFAIK, nobody complained about it in Emacs 22.

If there is a problem, I think you should add elements to the default
of rmail-retry-ignored-headers (and add a :version tag), rather than
using rmail-ignored-headers for this.

> I just looked at the old Rmail code and saw this:
>
> 	    (rmail-clear-headers "^sender:\\|^return-path:\\|^received:")
>
> which had got lost.  Would you prefer that fix?


What do you mean, "had got lost"? Equivalent code is there in
rmail-retry-failure in the trunk, right where you made your change:

 (rmail-delete-headers "^\\(sender\\|return-path\\|received\\):")

Re: emacs/lisp/mail rmail.el

[Richard M Stallman]

    What do you mean, "had got lost"? Equivalent code is there in
    rmail-retry-failure in the trunk, right where you made your change:

Indeed, it is.  You installed it on March 2.  But it wasn't operating
for me, since I had not compiled recently.  It looks like your change
fixed the bug I was trying to fix.  So I will remove my change.

recursive edit in isearch

[Chetan Pandya]

It looks like recursive edit in isearch mode will not save/restore. Current code will try to restore the buffer if the window buffer is different from the current buffer. 
A simple change is to make sure it is so that the buffer is not restored, in case the buffer changed in the mean time.

Change 

diff -u /emacs-23/lisp/isearch.el.~1.345.~ /emacs-23/lisp/isearch.el
--- /emacs-23/lisp/isearch.el.~1.345.~    Tue Feb 17 01:27:04 2009
+++ /emacs-23/lisp/isearch.el    Thu Mar 19 01:24:24 2009
@@ -811,8 +811,7 @@
   ;; the calling function until searching is completed) by entering
   ;; a recursive-edit and exiting it when done isearching.
   (if recursive-edit
-      (let ((isearch-recursive-edit t))
-    (recursive-edit)))
+    (save-excursion (set-buffer (window-buffer)) (recursive-edit)))
   isearch-success)