From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Comprehensive JSX support in Emacs Date: Fri, 15 Feb 2019 17:39:22 +0300 Message-ID: <95b4d4a2-f3ac-f28b-493f-606568247aed@yandex.ru> References: <1423022755.65233.1550120813763@privateemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="37638"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Thunderbird/65.0 To: Jackson Ray Hamilton , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 15 15:40:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1guef0-0009eP-74 for ged-emacs-devel@m.gmane.org; Fri, 15 Feb 2019 15:40:14 +0100 Original-Received: from localhost ([127.0.0.1]:40930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gueez-000321-4Z for ged-emacs-devel@m.gmane.org; Fri, 15 Feb 2019 09:40:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gueeP-00031k-Rl for emacs-devel@gnu.org; Fri, 15 Feb 2019 09:39:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gueeN-0006V6-PO for emacs-devel@gnu.org; Fri, 15 Feb 2019 09:39:37 -0500 Original-Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]:34180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gueeN-0006G5-IT for emacs-devel@gnu.org; Fri, 15 Feb 2019 09:39:35 -0500 Original-Received: by mail-lj1-x22c.google.com with SMTP id l5so5142063lje.1 for ; Fri, 15 Feb 2019 06:39:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9mbSmeKLHfplxV45K6YosIihZtGyPHVVQ7nr55svdFM=; b=rA/06dRUgMPp4gcQ9Lb4T6qv+F18tx8JIrrzVTD0IwioHI8wWGJ9itGBdbAUqNnrUS SyBKGgSRGkcl9IKctTqEs+tIgsOkF8l3lP+grxLU2IQJGYM/Z1Ro20aac7t/LiVtVVB2 tjttAFEfCmqXkFUkA4FaYUfZVsESvMBlEFjOyBNhTyVVZzEaKowEwQSSyJfciHZerA3y cDsg2QIhxNhqJuH3Mgf8JiPYMwKC9AFrYuM4o3bfvwzR4+AVuJJdkpYkc7j40jMYEKKN GT8VK7ZZ0zbqie/G5Vva/mtaAOjoR2sRVAyyY3GVcV6FLir97KCbCy9jtm3/Sj0q7a2z RBEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9mbSmeKLHfplxV45K6YosIihZtGyPHVVQ7nr55svdFM=; b=ORX+7cB4bKawvQpLAnjhw5X/myYZ6iT1HBxPhwePp/numfXNY0NoLSYH07D6mSajkl 6KAk7frjrUWtzyJRp7nowA8lrvBSjhM1Vu+7wzkgj3w3/YwjgSmPqcA5AvSinMbrXn1x aq5h9JLl3U9vGkprLmXp7yqoumDOkP1KveWV1h4upk3dbf7Wy6j5Az/fL17V0Lu720iX 879NtMMzaY1relwHpSkd4JhhyF1JTkEj5oc/9YEsOUaM9l1dqHriqSHhxSMdqUAD/TSB 8D7sWShEbGmSeDH72l1ZCh2yaE/SpRr6jmWxRML+uenQGYoztrHLLS7DYvl0YACJ+NDE wsNw== X-Gm-Message-State: AHQUAub42JVaJtED2cBWSjX2ueKTNY7HZAHRlsxqCUqUFx/fYxjI07Or kzhQaVpnuQbZq553jaykResBkdLr X-Google-Smtp-Source: AHgI3IZKlyE5hPKFZcdatms5MpMKQH0EKd2H5KvZM2K2C+LQV04lDp7qsyLHWYSUB6WBSPcALBmv7g== X-Received: by 2002:a2e:310a:: with SMTP id x10-v6mr5970955ljx.6.1550241565032; Fri, 15 Feb 2019 06:39:25 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id p5sm1221939ljg.44.2019.02.15.06.39.23 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 06:39:23 -0800 (PST) In-Reply-To: <1423022755.65233.1550120813763@privateemail.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233374 Archived-At: Hi Jackson, On 14.02.2019 08:06, Jackson Ray Hamilton wrote: > Recently, I finally resolved to “do my laundry,” with respect to > addressing the JSX indentation issues accumulated within debbugs and the > js2-mode GitHub repo (where lots of js-mode bugs accidentally get > filed).  In the past week, I assembled some test cases, drafted some > algorithms, and proceeded to implement a number of improvements to the > indentation logic. Thanks a lot for working on this. On my part, I can say I'm excited about indentation improvements. Creating jsx-specific variables that default to sgml- values sounds good. Regarding js?-jsx- mode deprecations, I'm ambivalent. The current design seems okay from my POV, that the thing Flycheck ends up having to do is not the end of the world (there are several major modes in that list already anyway). But if other people agree, all the best. I'd just prefer not to turn it on by default, in the absence of any indications that the current file is JSX.