From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: scratch/hash-table-perf 3e9e68333ae 16/35: Remove rehash-threshold and rehash-size struct members Date: Thu, 4 Jan 2024 20:52:22 +0200 Message-ID: <959d595d-862a-413c-ab5f-6f4067e4e8d2@gutov.dev> References: <170438379722.3921.9312235725296561206@vcs2.savannah.gnu.org> <20240104155642.6326FC00344@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3948"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: emacs-devel@gnu.org, =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 04 19:53:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rLSqC-0000gx-8k for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jan 2024 19:53:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLSpS-0002Yt-Fm; Thu, 04 Jan 2024 13:52:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLSpQ-0002YW-VQ for emacs-devel@gnu.org; Thu, 04 Jan 2024 13:52:28 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLSpP-0007iW-0o for emacs-devel@gnu.org; Thu, 04 Jan 2024 13:52:28 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2626E5C00F9; Thu, 4 Jan 2024 13:52:26 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 04 Jan 2024 13:52:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1704394346; x=1704480746; bh=U0lN+Chtpms7BMP+8kQo8LBGdBgUUSXuKFCIERtcwx0=; b= UrXCi8GqvMYoTfQmty/VzcZx6Cy055G1mEE08RdY0dTem3YvxqWH5BUMG5e91s5V rLzvQ8/i7jzWvSJOvatEKVQpFRP+/FGsvNhqyy71phjck7CXutRMz9Kg2PqNfWcW JifntP2NDB2TIBYE4xn972t7Ih3iNOXhobJA+QWnVCFC+KT0rWow2mZ+TZPtfRhV dnhyB2U6x5RYLVyKLskn+aAaOyLxf9CP6vHqUSGiOSN3eXuE8kJNauP6fl6rD1oN qwt7wpkM/zulxSonsGl6H9mATBo/E5luDyQGjLzenVFB0x+deamRY06v/jWwnuTl QrnbGEQdS7YIFHGa3N1hbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1704394346; x= 1704480746; bh=U0lN+Chtpms7BMP+8kQo8LBGdBgUUSXuKFCIERtcwx0=; b=y LmOlWTCiemp4egFhRQKA3NgOlztj5m6GsHfmohKBiXRvgzEPEf9p8ZZL1Rkw13N6 z5sVWsWoJoO/yhfWwesoB/GiWowrArMhHwWI/YUUTPgDUlaGp8y7yqOBuI/X2Klv sK+vCfhr/2iRK3iWZ6tJFel/uq5pzAwgYKoLA3bTCLkHle+LO3oD5k//762tObXq SsLC+zuSfxHiBuQTurROXGLrbfP1x6F73oJ6KENyhEIfUY67E0RlrO97ENZVi59F I5c3nQfMIrxIlaIOjIuso7t44a41sgQVvfUycYP/QgQcVCsRu5arygCdIsa6knT6 2yImKCBTsDlMYndDF8UFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdegjedguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepheekfedtveetkeehheffkedtffevfeffieellefhgfeguefhtdekfeeuveei udfgnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Jan 2024 13:52:24 -0500 (EST) Content-Language: en-US In-Reply-To: <20240104155642.6326FC00344@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=66.111.4.28; envelope-from=dmitry@gutov.dev; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314542 Archived-At: On 04/01/2024 17:56, Mattias Engdegård wrote: > branch: scratch/hash-table-perf > commit 3e9e68333ae15a6544e490851f80da3a8f9ef343 > Author: Mattias Engdegård > Commit: Mattias Engdegård > > Remove rehash-threshold and rehash-size struct members > > These parameters have no visible semantics and are hardly ever used, > so just use the default values for all hash tables. This saves > memory, shrinks the external representation, and will improve > performance. I'm curious whether any of these callers have tested with different values and found a difference in performance: https://github.com/search?q=%3Arehash-threshold+language%3A%22Emacs+Lisp%22&type=code&l=Emacs+Lisp