unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Faces in bash-ts-mode
Date: Sun, 5 Mar 2023 14:23:06 -0800	[thread overview]
Message-ID: <95855C48-0538-4171-8D31-C6F824755CF8@gmail.com> (raw)
In-Reply-To: <83bklacluc.fsf@gnu.org>



> On Mar 2, 2023, at 11:53 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> Is there an easy way of having some of the sh-script's special faces
> in bash-ts-mode?  The one I spotted to be missing is
> sh-escaped-newline, but maybe sh-quoted-exec is also missing?

I added support for sh-quoted-exec, but because tree-sitter ignores the escaped newline, it doesn’t show up in the parse tree, so it’s not as easy to support that.

I not an expert in bash syntax, can I assume that an backslash at the end of a line that’s not in a string must be an escaped newline?

> Also, do we use sh-heredoc face for here-documents in bash-ts-mode?
> If not, can we use it in that case?

We do, so that’s taken care of :-)

Yuan


  reply	other threads:[~2023-03-05 22:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03  7:53 Faces in bash-ts-mode Eli Zaretskii
2023-03-05 22:23 ` Yuan Fu [this message]
2023-03-06 12:49   ` Eli Zaretskii
2023-03-06 13:10   ` Yuri Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95855C48-0538-4171-8D31-C6F824755CF8@gmail.com \
    --to=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).