From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: lg.zevlg@gmail.com Newsgroups: gmane.emacs.devel Subject: Re: Loading svg from memory using custom filename for base_uri Date: Sat, 12 Dec 2020 08:46:10 +0300 Message-ID: <953508BA-5721-4BFF-AF28-54DF93DC7AD2@gmail.com> References: Mime-Version: 1.0 (1.0) Content-Type: multipart/alternative; boundary=Apple-Mail-C3A490CD-CAB3-47E9-8FB9-A7BB931912FF Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1620"; mail-complaints-to="usenet@ciao.gmane.io" To: Evgeny Zajcev , Alan Third , emacs-devel , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 12 06:47:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knxkq-0000Ks-2Y for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Dec 2020 06:47:40 +0100 Original-Received: from localhost ([::1]:35560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knxkp-0006tQ-3V for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Dec 2020 00:47:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knxjZ-0006R3-EM for emacs-devel@gnu.org; Sat, 12 Dec 2020 00:46:21 -0500 Original-Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:34079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knxjT-0005eT-8J; Sat, 12 Dec 2020 00:46:21 -0500 Original-Received: by mail-lf1-x133.google.com with SMTP id m19so16939605lfb.1; Fri, 11 Dec 2020 21:46:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:in-reply-to:to; bh=3SeHD/hjZ8bCXtafuyFTWfdI9wyhK7s0HplRPgominY=; b=gZ19C6vyYwUs7rnRhE0nKZgeghAvqGexuWu6lQPbiraOYt2IHW/gQuqSE1WjUhkwrd MLhrsfLXMdriKhhmaO7Qz7hivaWi277dWtJNcdRgoDxsSONc00Q+DH9zhWlXjA6ekBl6 yzYat/usryj0SQ7iN58MlGzOGOUh4rHo3ztChN80RRhclGpQBMC40Ca4S1cGlH3MtukG +T8TAYg9sIsnHYPm4Ph004Ilafy6G2lbckA1abgTTBxye9VRUJC+xcoGKVcuz+Ny8Ph4 uooEsie9cUubMxmSAZ/BeKkXBqAEIkG1bj8moB9C1NNEUAWf0cYX1lZXLOqAoio8dcCx LhjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:in-reply-to:to; bh=3SeHD/hjZ8bCXtafuyFTWfdI9wyhK7s0HplRPgominY=; b=hBjTNcYk+ltGt+oJcGEEbd0fcUbdgJRNxAlIX36LtQUaFSGKjPRBOFiS6T+gmNT/8t jDHBwYNob+63EH7wNI709WdgAtzna27idUYd5glNpOTEF/M+FsFts2u3kOrHpNPN5pCY j6Jvy9kqB2B9xz5KxjSmJA+ucH2/dLMQ8ZSlhU1ofqRSBGCpo5v8c00oBMk7NWeYhtha k6EzOPjkJp7Vh/4tTyeRbN3aAstf/3wYOVfQS91FUqFHNxxRrS/vHFUPP+wgcQeC+dpb mixrlyqysNFE7FeUiEkRIcm845easTgXDrZbE8Kry3BTH8tDBOnKMbC6j4O8YIts62eL wmwg== X-Gm-Message-State: AOAM533or4RH16qF/ozUFof62q/kvLD1GkjcSmteBM1hBSeRKk6wwcTZ fwauIC9WaQYQXqbFsbeCSwKtzJJlXKg= X-Google-Smtp-Source: ABdhPJzTpwAsyMwTMTbnKxOUmYBE96K7yuiBAP2pPRYfDMBna6qXjt6b3UsNvXpy0muNkkHhAf5K4A== X-Received: by 2002:ac2:4147:: with SMTP id c7mr5572625lfi.396.1607751972143; Fri, 11 Dec 2020 21:46:12 -0800 (PST) Original-Received: from localhost.localdomain ([2.92.196.30]) by smtp.gmail.com with ESMTPSA id n12sm1274914ljj.82.2020.12.11.21.46.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Dec 2020 21:46:11 -0800 (PST) In-Reply-To: X-Mailer: iPad Mail (18A373) Received-SPF: pass client-ip=2a00:1450:4864:20::133; envelope-from=lg.zevlg@gmail.com; helo=mail-lf1-x133.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260710 Archived-At: --Apple-Mail-C3A490CD-CAB3-47E9-8FB9-A7BB931912FF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > 4 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3., =D0=B2 02:02, Evgeny Zajcev =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >=20 > =EF=BB=BF >=20 >=20 > =D0=BF=D1=82, 4 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 01:11, Evgeny Zajc= ev : >>=20 >>=20 >> =D1=87=D1=82, 3 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 22:57, Alan Third= : >>>> On Thu, Dec 03, 2020 at 08:50:15PM +0300, Evgeny Zajcev wrote: >>>> >=20 >>>> > Here is updated patch, with support for `:base-uri` for :file image s= pec as >>>> > well >>>>=20 >>>> It looks good to me. There are two things I think we need. One is to >>>> add an entry for :base-uri to the svg_format array in image.c, >>> done! >>>=20 >>> and >>> some documentation, if you fancy writing it? >>>=20 >> Documentation better to write when `svg-embed` will support this feature.= >=20 > I wrote a new function `svg-embed-base-uri-image' to do the job, and wrote= documentation for it. >=20 JFYI: I=E2=80=99ve been using Emacs with this patch applied for one week, ut= ilizing svg file embeding heavily, works as expected without any issues --=20 lg --Apple-Mail-C3A490CD-CAB3-47E9-8FB9-A7BB931912FF Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

4 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3., =D0=B2 0= 2:02, Evgeny Zajcev <lg.zevlg@gmail.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81= =D0=B0=D0=BB(=D0=B0):

=EF=BB=BF


=D0=BF=D1=82, 4= =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 01:11, Evgeny Zajcev <lg.zevlg@gmail.com>:

=

=D1= =87=D1=82, 3 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 22:57, Alan Third <<= a href=3D"mailto:alan@idiocy.org" target=3D"_blank">alan@idiocy.org>:=
On Thu, Dec 03, 2= 020 at 08:50:15PM +0300, Evgeny Zajcev wrote:
>
> Here is updated patch, with support for `:base-uri` for :file image spe= c as
> well

It looks good to me. There are two things I think we need. One is to
add an entry for :base-uri to the svg_format array in image.c,
=
done!

and
some documentation, if you fancy writing it?

Documentation better to write when `svg-embed` will su= pport this feature.

I wrot= e a new function `svg-embed-base-uri-image' to do the job, and wrote documen= tation for it.


JFYI: I= =E2=80=99ve been using Emacs with this patch applied for one week, utilizing= svg file embeding heavily, works as expected without any issues

-- 
lg

= --Apple-Mail-C3A490CD-CAB3-47E9-8FB9-A7BB931912FF--